From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754221AbcFQAd3 (ORCPT ); Thu, 16 Jun 2016 20:33:29 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:44621 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751795AbcFQAd2 (ORCPT ); Thu, 16 Jun 2016 20:33:28 -0400 Date: Thu, 16 Jun 2016 17:33:26 -0700 (PDT) Message-Id: <20160616.173326.1960266414450397084.davem@davemloft.net> To: arnd@arndb.de Cc: Dept-GELinuxNICDev@qlogic.com, rajesh.borundia@qlogic.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] net: qlcnic: don't set unused function argument From: David Miller In-Reply-To: <20160616113831.4108439-2-arnd@arndb.de> References: <20160616113831.4108439-1-arnd@arndb.de> <20160616113831.4108439-2-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 16 Jun 2016 17:33:27 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Thu, 16 Jun 2016 13:38:22 +0200 > We get a warning for qlcnic_83xx_get_mac_address when building with > "make W=1": > > drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c: In function 'qlcnic_83xx_get_mac_address': > drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:2156:8: error: parameter 'function' set but not used [-Werror=unused-but-set-parameter] > > Clearly this is harmless, but there is also no point for setting > the variable, so we can simply remove the assignment. > > Signed-off-by: Arnd Bergmann Applied to net-next.