From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752848AbcFPGut (ORCPT ); Thu, 16 Jun 2016 02:50:49 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:26786 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752079AbcFPGur (ORCPT ); Thu, 16 Jun 2016 02:50:47 -0400 Date: Thu, 16 Jun 2016 09:50:32 +0300 From: Dan Carpenter To: Or Gerlitz Cc: Leon Romanovsky , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] devlink: clean up a condition Message-ID: <20160616065032.GB23129@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.6.0 (2016-04-01) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Presumably having a _get() function implies that we also have a _set() function but lets make it match when we're calling. Signed-off-by: Dan Carpenter diff --git a/net/core/devlink.c b/net/core/devlink.c index a4f88cb..b2e592a 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -1461,7 +1461,7 @@ static int devlink_nl_cmd_eswitch_mode_set_doit(struct sk_buff *skb, mode = nla_get_u16(info->attrs[DEVLINK_ATTR_ESWITCH_MODE]); - if (ops && ops->eswitch_mode_get) + if (ops && ops->eswitch_mode_set) return ops->eswitch_mode_set(devlink, mode); return -EOPNOTSUPP; }