From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754302AbcFPLiY (ORCPT ); Thu, 16 Jun 2016 07:38:24 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:60386 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754261AbcFPLiU (ORCPT ); Thu, 16 Jun 2016 07:38:20 -0400 From: Arnd Bergmann To: Sudeep Dutt , Ashutosh Dixit Cc: Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: [PATCH 3/5] mic: remove unused function arg Date: Thu, 16 Jun 2016 13:38:24 +0200 Message-Id: <20160616113831.4108439-4-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20160616113831.4108439-1-arnd@arndb.de> References: <20160616113831.4108439-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:Ugy0SSb0mf2HvPdhCRDcESl1VepFrd/LxBuJTMubLcN29TFKHrP MrVTYsPNTOfrysHj/1Nm44OcArLdsKdUG14uSIdGHUmg6bvq7ToHRcZB7BdtSdxyLXOKvCf cmdUwJWdLAt9UGYVdZqGTUyvLli8KGM2H+KJhhmkaessz/lGYbcZQ1WM4jcu6Q5jPKTsaWG j8LFb5MQFAG48betCLnOA== X-UI-Out-Filterresults: notjunk:1;V01:K0:tedtm8zEF+E=:oZxuaDvNtJ7VY6s2FHfu++ rUihNLfDgRNBSdwgshDZKHsicMwl5KcsFlpIj+xjFn3CEKk2n+EcNHIxqsgy5ezvIbSmjLoGM J3W8L+HqHI8SobtSXSWyqGMydg8AEXQyynykPSYJS5wdheh94o34E4IQoV2MPJw+RyJx6UQO0 o/ca2fQk32G+uJLq0ViiMLgBtm+l9QIIX9cdqrKtWbKdaDQHnRxXz06KQs3ckr6Vzm+c+4RMd f9WzN61mVjPbGZtoBvLw7cPect/1HTFkbAVHfd3SENRTag88TIFawui6rDj86GT/f06nyIb2a q4XKmVvCM0MGO5UkddI5iM//seANdSwt5nLfKan+4dPgTJkBkfzQZ47fLaWK5Ng5UWTTxO8L4 i1Ykhi7FfwieAJUi1E4shl26ahVyXdqdaZqCqQ1fafVoxWkWhQ0+PXGmjQGyGwQCYidiGNW7M j2P+oG70RkHDUQsCqf4Xearb+jlnC0TsZGLbNNY1WIc1BbDCY+Gkvz2DRIHQH89ITarlX+pDO 71tR/oSjHzeOW2qVztg1sm/otxIYJ2OxNkPv5NvT7RXfK6+YV+MBswB6ZmjpbzGjRqd36+SYJ J98JZFCPM/7aHueeBL0USnWg8KSLhQo3FE4dGiHHQss8ucSA4OMJogK8eexiD1aL6aYst2Pe0 IQIcfO5RTu4+MU8DN2pagUKrd3Jde9U2U22kWyacptn1IOU62aFzyDviEqUCZIXWeFjKDOld3 yIz8JeoHQYUWUp5u Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When building with W=1, the __scif_rma_destroy_tcw function causes a harmless warning about an argument variable that is modified but not used: drivers/misc/mic/scif/scif_dma.c: In function ‘__scif_rma_destroy_tcw’: drivers/misc/mic/scif/scif_dma.c:118:27: error: parameter ‘ep’ set but not used [-Werror=unused-but-set-parameter] In this case, we can just remove the argument, since all callers are in the same file. Signed-off-by: Arnd Bergmann --- drivers/misc/mic/scif/scif_dma.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/misc/mic/scif/scif_dma.c b/drivers/misc/mic/scif/scif_dma.c index cd01a0efda6b..64d5760d069a 100644 --- a/drivers/misc/mic/scif/scif_dma.c +++ b/drivers/misc/mic/scif/scif_dma.c @@ -115,7 +115,6 @@ int scif_reserve_dma_chan(struct scif_endpt *ep) */ static void __scif_rma_destroy_tcw(struct scif_mmu_notif *mmn, - struct scif_endpt *ep, u64 start, u64 len) { struct list_head *item, *tmp; @@ -128,7 +127,6 @@ void __scif_rma_destroy_tcw(struct scif_mmu_notif *mmn, list_for_each_safe(item, tmp, &mmn->tc_reg_list) { window = list_entry(item, struct scif_window, list); - ep = (struct scif_endpt *)window->ep; if (!len) break; start_va = window->va_for_temp; @@ -146,7 +144,7 @@ static void scif_rma_destroy_tcw(struct scif_mmu_notif *mmn, u64 start, u64 len) struct scif_endpt *ep = mmn->ep; spin_lock(&ep->rma_info.tc_lock); - __scif_rma_destroy_tcw(mmn, ep, start, len); + __scif_rma_destroy_tcw(mmn, start, len); spin_unlock(&ep->rma_info.tc_lock); } @@ -169,7 +167,7 @@ static void __scif_rma_destroy_tcw_ep(struct scif_endpt *ep) spin_lock(&ep->rma_info.tc_lock); list_for_each_safe(item, tmp, &ep->rma_info.mmn_list) { mmn = list_entry(item, struct scif_mmu_notif, list); - __scif_rma_destroy_tcw(mmn, ep, 0, ULONG_MAX); + __scif_rma_destroy_tcw(mmn, 0, ULONG_MAX); } spin_unlock(&ep->rma_info.tc_lock); } -- 2.9.0