From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754358AbcFPLjO (ORCPT ); Thu, 16 Jun 2016 07:39:14 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:52115 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753849AbcFPLjM (ORCPT ); Thu, 16 Jun 2016 07:39:12 -0400 From: Arnd Bergmann To: Felipe Balbi Cc: Arnd Bergmann , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/5] usb: pxa27x_udc: remove unused function argument Date: Thu, 16 Jun 2016 13:38:25 +0200 Message-Id: <20160616113831.4108439-5-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20160616113831.4108439-1-arnd@arndb.de> References: <20160616113831.4108439-1-arnd@arndb.de> X-Provags-ID: V03:K0:Gon9gfxuj/Y81MMDtjJELrpwo+6LLqJziVftAbbLaAovYtOnd+Q FMS1Cf59b/RCjDneDBvgXuVuSYtBRAnu7hzTnOsLEwn9w18KDXwzz6SrSsJwOTDicrP+gVa 0wrSFvkIOD1AhKgT5AUF5nMSPAFM0ve4ctsFnpJJLP8ehiwdVL0T8VQdSGbxSoFHu9khl5k PKdfzwUWwJeNfm7aIGkpg== X-UI-Out-Filterresults: notjunk:1;V01:K0:Wuz3u56SNcM=:nFh9biK6dPnZ573l4sq7Mc NjhkGnY/MGlRuQDUbWSP6z7GLrn1APYzM2xXUX+eMLfyO8GbBCza0mKqVAOCutOiBqsPhHvxA e3Ia3wAkHcRMNXTt5Pjn0ZWXxAznPtvQt6s6e01TDaH+sn9EVCqnw0p+gOepcNpXG4gifV/s4 AqaaAcIM1vXofCGrVr3L22jX2DZKr/sW24nHvfr3QAmtuaPWsU3p2l3bZxOwMSGvIIo0s5GWF 8e/klwHl2KIAVPOEvA98A+SU2bwuuwelIhk5UE3UHcLW0fecogSaFmEWRfE/Eo/eZmZALqysa ogxb3n9mxQAJRbWY7gfxJeOc9JcfrNDk8CUHWgz0hcpOOnULBVwC9GWfsYuH/yA+qFFYTAFQz ZKauiNskCD7T3BWnwZ4zdAoV4HV8yHVFJbKPx2oSGR9N9WrWzEF2dIDjmwH4UwQFbJkDYVD26 2u1l0OsJ9JXSMUIL8MxyDS7HuewSBBNFAcu3d8nfvZDkcAGjkwE9P+KXQBhVbPlv4K31pis60 r7gybKQmWcQA4F5KT3h7Gk9fSg/MUpqTopIKzW0uKH8PEfB5uVq0hjDNrAlX/8xNvkjp1HFf4 q3UA3nZDQPQ4nfb3XQIY6qshJnU6drU8l6//Pv2lh9YuAuhrZUIKpQmhrRR2MUemQjOQPanXg r4Hc7OkGmFLaIg7tSOHBdnTlLYZsSeRn+dMNJJcVKEEveL32C33+RTRWLiYG25lg2p5I= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get a warning for this when building with W=1 because the argument gets assigned to something else but never read: drivers/usb/gadget/udc/pxa27x_udc.c: In function 'stop_activity': drivers/usb/gadget/udc/pxa27x_udc.c:1828:74: error: parameter 'driver' set but not used [-Werror=unused-but-set-parameter] This remove the argument entirely. Signed-off-by: Arnd Bergmann --- drivers/usb/gadget/udc/pxa27x_udc.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c b/drivers/usb/gadget/udc/pxa27x_udc.c index 001a3b74a993..ad140aa00132 100644 --- a/drivers/usb/gadget/udc/pxa27x_udc.c +++ b/drivers/usb/gadget/udc/pxa27x_udc.c @@ -1825,13 +1825,10 @@ fail: * Disables all udc endpoints (even control endpoint), report disconnect to * the gadget user. */ -static void stop_activity(struct pxa_udc *udc, struct usb_gadget_driver *driver) +static void stop_activity(struct pxa_udc *udc) { int i; - /* don't disconnect drivers more than once */ - if (udc->gadget.speed == USB_SPEED_UNKNOWN) - driver = NULL; udc->gadget.speed = USB_SPEED_UNKNOWN; for (i = 0; i < NR_USB_ENDPOINTS; i++) @@ -1848,7 +1845,7 @@ static int pxa27x_udc_stop(struct usb_gadget *g) { struct pxa_udc *udc = to_pxa(g); - stop_activity(udc, NULL); + stop_activity(udc); udc_disable(udc); udc->driver = NULL; @@ -2296,7 +2293,7 @@ static void irq_udc_reset(struct pxa_udc *udc) if ((udccr & UDCCR_UDA) == 0) { dev_dbg(udc->dev, "USB reset start\n"); - stop_activity(udc, udc->driver); + stop_activity(udc); } udc->gadget.speed = USB_SPEED_FULL; memset(&udc->stats, 0, sizeof udc->stats); -- 2.9.0