From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754504AbcFPMhj (ORCPT ); Thu, 16 Jun 2016 08:37:39 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33432 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754021AbcFPMhh (ORCPT ); Thu, 16 Jun 2016 08:37:37 -0400 Date: Thu, 16 Jun 2016 14:37:33 +0200 From: Daniel Vetter To: Arnd Bergmann Cc: Mark Yao , David Airlie , Heiko Stuebner , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Chris Zhong , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] drm: rockchip: select DRM_GEM_CMA_HELPER Message-ID: <20160616123733.GB23520@phenom.ffwll.local> Mail-Followup-To: Arnd Bergmann , Mark Yao , David Airlie , Heiko Stuebner , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Chris Zhong , linux-arm-kernel@lists.infradead.org References: <20160616122800.1174015-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160616122800.1174015-1-arnd@arndb.de> X-Operating-System: Linux phenom 4.6.0-rc5+ User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 16, 2016 at 02:27:57PM +0200, Arnd Bergmann wrote: > The rockchip drm driver started using drm_gem_cma_vm_ops, but that might > not be part of the kernel, causing the link to fail: > > drivers/gpu/built-in.o:(.data+0xb234): undefined reference to `drm_gem_cma_vm_ops' > > This adds a Kconfig 'select' statement to enable it like the other > user do. > > Signed-off-by: Arnd Bergmann > Fixes: 80f67cd80add ("drm/rockchip: Use cma gem vm ops") Applied to drm-misc, thanks. -Daniel > --- > drivers/gpu/drm/rockchip/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig > index d30bdc38a760..e48611e83c03 100644 > --- a/drivers/gpu/drm/rockchip/Kconfig > +++ b/drivers/gpu/drm/rockchip/Kconfig > @@ -2,6 +2,7 @@ config DRM_ROCKCHIP > tristate "DRM Support for Rockchip" > depends on DRM && ROCKCHIP_IOMMU > depends on RESET_CONTROLLER > + select DRM_GEM_CMA_HELPER > select DRM_KMS_HELPER > select DRM_KMS_FB_HELPER > select DRM_PANEL > -- > 2.9.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch