From: Catalin Marinas <catalin.marinas@arm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: James Morse <james.morse@arm.com>,
Alexander Potapenko <glider@google.com>,
linux-arm-kernel@lists.infradead.org,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
marc.zyngier@arm.com, Will Deacon <will.deacon@arm.com>,
LKML <linux-kernel@vger.kernel.org>,
Quentin Casasnovas <quentin.casasnovas@oracle.com>,
Kostya Serebryany <kcc@google.com>,
syzkaller <syzkaller@googlegroups.com>,
Dmitriy Vyukov <dvyukov@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Christoffer Dall <christoffer.dall@linaro.org>
Subject: Re: [PATCH v2] arm64: allow building with kcov coverage on ARM64
Date: Thu, 16 Jun 2016 17:39:09 +0100 [thread overview]
Message-ID: <20160616163909.GG18752@e104818-lin.cambridge.arm.com> (raw)
In-Reply-To: <20160616163258.GA1459@leverpostej>
On Thu, Jun 16, 2016 at 05:32:59PM +0100, Mark Rutland wrote:
> On Thu, Jun 16, 2016 at 05:25:31PM +0100, Catalin Marinas wrote:
> > On Thu, Jun 16, 2016 at 04:44:12PM +0100, Mark Rutland wrote:
> > > On Thu, Jun 16, 2016 at 05:20:03PM +0200, Alexander Potapenko wrote:
> > > > I think it's time to ask now :)
> > > > If I receive "Tested-by" or "Acked-by" responses, do I need to send
> > > > out a patch adding them, or should I rely on the maintainer taking the
> > > > patch to the tree?
> > > > The first option reduces the amount of work done by the maintainer,
> > > > while the second one reduces the traffic in the list.
> > > > Sorry, I couldn't find the answer in the manuals.
> > >
> > > It's up to the maintainer, so it varies. The best thing to do is to ask
> > > the maintainer what they'd prefer.
> > >
> > > From my experience, Catalin is usually happy to add tags, so I suspect
> > > he'd be happy to do so for this patch (assuming he's happy to pick it
> > > up). I'll leave it for him to say either way.
> >
> > I usually cherry-pick tags that I see in reply to the *latest* version
> > of the patch (I have a rudimentary script to do this).
> >
> > I noticed that there was an ack on v1 form Marc Z that's missing in v2.
>
> I believe Marc's reply [1] was to v3 [2], it's just that the version was
> missing form the subject, and discussions continued on v2 in the mean
> time.
OK, thanks for clarification. I thought the one with most replies was
the latest ;).
> > Maybe it no longer applies, I can't tell, but I usually expect
> > subsequent versions of a patch to include all the previously given acks
> > (of course, if they still apply, sometimes a patch rewrite means
> > dropping those tags).
>
> I guess the simplest thing to do is for Alexander to send a v4 with the
> tags accumulated, assuming James's Tested-by is applicable to v3 with
> the boot/Makefile hunk removed. James?
Even better.
--
Catalin
prev parent reply other threads:[~2016-06-16 16:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 16:57 Alexander Potapenko
2016-06-14 17:16 ` Alexander Potapenko
2016-06-14 17:55 ` Mark Rutland
2016-06-14 18:16 ` Alexander Potapenko
2016-06-15 9:25 ` Mark Rutland
2016-06-15 11:44 ` Mark Rutland
2016-06-15 11:53 ` Alexander Potapenko
2016-06-15 14:25 ` Mark Rutland
2016-06-15 14:36 ` Dmitry Vyukov
2016-06-15 15:05 ` Mark Rutland
2016-06-15 15:16 ` Dmitry Vyukov
2016-06-16 10:47 ` James Morse
2016-06-16 15:20 ` Alexander Potapenko
2016-06-16 15:44 ` Mark Rutland
2016-06-16 16:25 ` Catalin Marinas
2016-06-16 16:32 ` Mark Rutland
2016-06-16 16:36 ` Alexander Potapenko
2016-06-16 16:36 ` James Morse
2016-06-16 16:39 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160616163909.GG18752@e104818-lin.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=christoffer.dall@linaro.org \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=james.morse@arm.com \
--cc=kcc@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=quentin.casasnovas@oracle.com \
--cc=syzkaller@googlegroups.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®