From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754092AbcFPSTQ (ORCPT ); Thu, 16 Jun 2016 14:19:16 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:33016 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751930AbcFPSTP (ORCPT ); Thu, 16 Jun 2016 14:19:15 -0400 Date: Thu, 16 Jun 2016 20:19:12 +0200 From: Michal Hocko To: "Odzioba, Lukasz" Cc: "Hansen, Dave" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "akpm@linux-foundation.org" , "kirill.shutemov@linux.intel.com" , "aarcange@redhat.com" , "vdavydov@parallels.com" , "mingli199x@qq.com" , "minchan@kernel.org" , "Anaczkowski, Lukasz" , "Shutemov, Kirill" Subject: Re: [PATCH 1/1] mm/swap.c: flush lru_add pvecs on compound page arrival Message-ID: <20160616181912.GQ6836@dhcp22.suse.cz> References: <1465396537-17277-1-git-send-email-lukasz.odzioba@intel.com> <57583A49.30809@intel.com> <20160608160653.GB21838@dhcp22.suse.cz> <575848F9.2060501@intel.com> <20160609122140.GE24777@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 16-06-16 18:08:57, Odzioba, Lukasz wrote: > On Thru 09-06-16 02:22 PM Michal Hocko wrote: > > I agree it would be better to do the same for others as well. Even if > > this is not an immediate problem for those. > > I am not able to find clear reasons why we shouldn't do it for the rest. > Ok so what do we do now? I'll send v2 with proposed changes. > Then do we still want to have stats on those pvecs? > In my opinion it's not worth it now. I think the fix has a higher priority - we also want to backport it to stable trees IMO. We can discuss the stats and how to present them later. -- Michal Hocko SUSE Labs