From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755170AbcFQAje (ORCPT ); Thu, 16 Jun 2016 20:39:34 -0400 Received: from mail.windriver.com ([147.11.1.11]:43563 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754333AbcFQAib (ORCPT ); Thu, 16 Jun 2016 20:38:31 -0400 From: Paul Gortmaker To: CC: Paul Gortmaker , Alexandre Belloni , Alexandre Courbot , Boris Brezillon , Ezequiel Garcia , Jason Cooper , Jean-Jacques Hiblot , Krzysztof Kozlowski , Kukjin Kim , Nicolas Ferre , Pankaj Dubey , Roger Quadros , Stephen Warren , Thierry Reding , Thomas Petazzoni , Tony Lindgren , , , Subject: [PATCH 0/6] memory: remove modular usage from non-modular drivers Date: Thu, 16 Jun 2016 20:37:42 -0400 Message-ID: <20160617003748.12188-1-paul.gortmaker@windriver.com> X-Mailer: git-send-email 2.8.4 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It seems that drivers/memory/ doesn't have a single maintainer, so please feel free to pick up just one or two patches from this as appropriate. For anyone new to the underlying goal of this cleanup, we are trying to not use module support for code that can never be built as a module since: (1) it is easy to accidentally write unused module_exit and remove code (2) it can be misleading when reading the source, thinking it can be modular when the Makefile and/or Kconfig prohibit it (3) it requires the include of the module.h header file which in turn includes nearly everything else, thus adding to CPP overhead. (4) it gets copied/replicated into other code and spreads like weeds. Changes seen here cover the following categories: -just replacement of modular macros with their non-modular equivalents that CPP would have inserted anyway -the removal of including module.h ; replaced with init.h as required based on whether the file already had it. -the removal of any/all unused/orphaned __exit functions that would never be called/exercised. -the removal of any ".remove" functions that were hooked into the driver struct. This ".remove" function would of course not be called from the __exit function since that was never run. However in theory, someone could have triggered it via sysfs unbind, even though there isn't a sensible use case for doing so. So to cover that possibility, we've also disabled sysfs unbind in these drivers. There are no initcall level changes here; everything continues to use the level of initcall it had before. So no risk of regressions from that exists here. Build tested for several different key arch on a recent linux-next tree to ensure no silly typos crept in. FAQ: Why not make it tristate? ------------------------------ Upon detecting a non-modular driver making modular references, I don't immediately convert them to tristate, since it increases functionality that I can't readily test, and it may not have a sensible use case (e.g. in the case of core arch support relating to timer ticks or similar.) So instead the modular references are removed w/o changing the existing functionality by default. However there is no reason the original author or an interested user with the capability to test can't nominate a driver to be tristate either as the original intent, or as a functional and tested use case. Paul. --- Cc: Alexandre Belloni Cc: Alexandre Courbot Cc: Boris Brezillon Cc: Ezequiel Garcia Cc: Jason Cooper Cc: Jean-Jacques Hiblot Cc: Krzysztof Kozlowski Cc: Kukjin Kim Cc: Nicolas Ferre Cc: Pankaj Dubey Cc: Roger Quadros Cc: Stephen Warren Cc: Thierry Reding Cc: Thomas Petazzoni Cc: Tony Lindgren Cc: linux-omap@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-tegra@vger.kernel.org Paul Gortmaker (6): memory: atmel-sdramc: make it explicitly non-modular memory: mvebu-devbus: make it explicitly non-modular memory: omap-gpmc: make it explicitly non-modular memory: tegra20-mc: make it explicitly non-modular memory: samsung/exynos-srom: make it explicitly non-modular memory: atmel-ebi: make it explicitly non-modular drivers/memory/atmel-ebi.c | 9 ++------- drivers/memory/atmel-sdramc.c | 11 ++++------- drivers/memory/mvebu-devbus.c | 11 ++++------- drivers/memory/omap-gpmc.c | 10 ---------- drivers/memory/samsung/exynos-srom.c | 21 +++------------------ drivers/memory/tegra20-mc.c | 11 ++++------- 6 files changed, 17 insertions(+), 56 deletions(-) -- 2.8.4