From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754727AbcFQAnZ (ORCPT ); Thu, 16 Jun 2016 20:43:25 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:55190 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753830AbcFQAnW (ORCPT ); Thu, 16 Jun 2016 20:43:22 -0400 X-AuditID: cbfee690-f79056d000001327-6e-5763479f0ab0 Date: Fri, 17 Jun 2016 09:43:11 +0900 From: Andi Shyti To: Lars-Peter Clausen Cc: Mark Brown , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti Subject: Re: [PATCH] spi: add spi_sync_single_transfer wrapper for single spi_transfer Message-id: <20160617004311.GA911@samsunx.samsung> References: <1466034046-718-1-git-send-email-andi.shyti@samsung.com> <5762CF88.4060800@metafoo.de> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-disposition: inline In-reply-to: <5762CF88.4060800@metafoo.de> User-Agent: Mutt/1.6.0 (2016-04-01) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMIsWRmVeSWpSXmKPExsWyRsSkUHe+e3K4wfsmeYvFP54zWUx9+ITN Ysnk+awWl3fNYbNo/HiT3YHV4/qST8wem1Z1snkseXOI1ePzJrkAligum5TUnMyy1CJ9uwSu jFuLL7AVXGCtOPX9H2MD4wGWLkZODgkBE4m3O44xQdhiEhfurWfrYuTiEBJYwSgx//hrdpii XTM3MEEkljJKLNy0hxXC+cgose7pPLB2FgFVibubLjGD2GwCmhJNt3+wgdgiAhoS/99MApvE LFArMeHzIaDVHBzCAhESi97VgYR5BYwkGhZ1Qc3cwSjReOMhE0RCUOLH5HssEL1aEut3HmeC sKUlHv2dATaTEyh+fkMTG8hMUQFlibvLgiCO3sUuseucA8RpAhLfJkOslRCQldh0gBmiRFLi 4IobLBMYxWYhWTYLybJZSJYtYGRexSiaWpBcUJyUXmSiV5yYW1yal66XnJ+7iREYV6f/PZuw g/HeAetDjAIcjEo8vBFSyeFCrIllxZW5hxhNga6YyCwlmpwPjN68knhDYzMjC1MTU2Mjc0sz JXHe11I/g4UE0hNLUrNTUwtSi+KLSnNSiw8xMnFwSjUwaj9YOu3JE3s3idMf4kyUH/3MKbu3 kt8+6WPrruITcd3slyTjSk4f8I6cGHBMXSiq5aPrz6t7O0XmTdnpyPjPmdHs3PTXWzz8PWx5 3/Btlr8gw7ZYYrrtiQsNlsXcLcETZ7SEHei9IqKwQHvxzskPJGZ77bz+Yc7yv0nqs+25nOb+ ab18Z/qReiWW4oxEQy3mouJEANaYDaamAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIIsWRmVeSWpSXmKPExsVy+t9jAd357snhBp37pSwW/3jOZDH14RM2 iyWT57NaXN41h82i8eNNdgdWj+tLPjF7bFrVyeax5M0hVo/Pm+QCWKIaGG0yUhNTUosUUvOS 81My89JtlbyD453jTc0MDHUNLS3MlRTyEnNTbZVcfAJ03TJzgBYrKZQl5pQChQISi4uV9O0w TQgNcdO1gGmM0PUNCYLrMTJAAwlrGDNuLb7AVnCBteLU93+MDYwHWLoYOTkkBEwkds3cwARh i0lcuLeerYuRi0NIYCmjxMJNe1ghnI+MEuuezgOrYhFQlbi76RIziM0moCnRdPsHG4gtIqAh 8f/NJHYQm1mgVmLC50NAGzg4hAUiJBa9qwMJ8woYSTQs6oKauYNRovHGQyaIhKDEj8n3WCB6 tSTW7zzOBGFLSzz6OwNsJidQ/PyGJjaQmaICyhJ3lwVNYBSYhaR7FpLuWUi6FzAyr2KUSC1I LihOSs81zEst1ytOzC0uzUvXS87P3cQIjt5nUjsYD+5yP8QowMGoxMO7Qzk5XIg1say4MvcQ owQHs5IIb6kTUIg3JbGyKrUoP76oNCe1+BCjKTA8JjJLiSbnAxNLXkm8obGJmZGlkbmhhZGx uZI47+P/68KEBNITS1KzU1MLUotg+pg4OKUaGA22dkZWnHL6fyp613Q/8dmsszSqJzko73b2 VledIdwgHrH+u4jxPp+tCyZNtvn+Vb6jzWTPq7AM+9ULF/NeYMh/+/PWJB7+88kRrpUlv+76 bX33TeoB/5zj0b8L3VZVbdi1ZPrz/REzeRZlfG2wu9m6+9mrR5vjyiLOvyp+c+jJ0YfFSf0r l6krsRRnJBpqMRcVJwIAlWk3+PQCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lars, > > The spi_sync_single_transfer function calls spi_sync_transfer > > with a single spi_transfer element, instead of an array. > > So, what's the advantage of using this as opposed to calling > spi_sync_transfer with a 1 for the number of transfers? Not much, but it keeps the code a bit nicer to read for those using spi_sync_transfer with only one spi_transfer. Besides it's also more understandable what the function itself does and there would not be any need to jump into the spi_sync_transfer to check what the number '1' is needed for (for example it's not a boolean 'true' value). I checked and there are quite many uses of spi_sync_transfer with only 1 transfer. Thanks, Andi