From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754676AbcFQHiO (ORCPT ); Fri, 17 Jun 2016 03:38:14 -0400 Received: from down.free-electrons.com ([37.187.137.238]:40115 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752665AbcFQHiM convert rfc822-to-8bit (ORCPT ); Fri, 17 Jun 2016 03:38:12 -0400 Date: Fri, 17 Jun 2016 09:38:09 +0200 From: Boris Brezillon To: Nicolas Ferre Cc: Paul Gortmaker , , Alexandre Belloni , Jean-Jacques Hiblot Subject: Re: [PATCH 6/6] memory: atmel-ebi: make it explicitly non-modular Message-ID: <20160617093809.5c8900e8@bbrezillon> In-Reply-To: <5763A84E.6060301@atmel.com> References: <20160617003748.12188-1-paul.gortmaker@windriver.com> <20160617003748.12188-7-paul.gortmaker@windriver.com> <5763A84E.6060301@atmel.com> Organization: Free Electrons X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 17 Jun 2016 09:35:42 +0200 Nicolas Ferre wrote: > Le 17/06/2016 02:37, Paul Gortmaker a écrit : > > The Kconfig currently controlling compilation of this code is: > > > > drivers/memory/Kconfig:config ATMEL_EBI > > drivers/memory/Kconfig: bool "Atmel EBI driver" > > > > ...meaning that it currently is not being built as a module by > > anyone. > > > > Lets remove the few remaining modular references, so that when > > reading the driver there is no doubt it is builtin-only. > > > > Since module_platform_driver() uses the same init level priority as > > builtin_platform_driver() the init ordering remains unchanged with > > this commit. > > > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > > > We also delete the MODULE_LICENSE tag etc. since all that > > information is already contained at the top of the file in the > > comments. > > > > Cc: Boris Brezillon > > Cc: Alexandre Belloni > > Cc: Jean-Jacques Hiblot > > Cc: Nicolas Ferre > > Acked-by: Nicolas Ferre Acked-by: Boris Brezillon > > We'll have to take the two atmel-related drivers through our git trees > and arm-soc. > > Thanks Paul. Bye. > > > Signed-off-by: Paul Gortmaker > > --- > > drivers/memory/atmel-ebi.c | 9 ++------- > > 1 file changed, 2 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/memory/atmel-ebi.c b/drivers/memory/atmel-ebi.c > > index 17d9d3f60f20..f87ad6f5d2dc 100644 > > --- a/drivers/memory/atmel-ebi.c > > +++ b/drivers/memory/atmel-ebi.c > > @@ -14,7 +14,7 @@ > > #include > > #include > > #include > > -#include > > +#include > > #include > > #include > > > > @@ -648,7 +648,6 @@ static const struct of_device_id > > at91_ebi_id_table[] = { }, > > { /* sentinel */ } > > }; > > -MODULE_DEVICE_TABLE(of, at91_ebi_id_table); > > > > static int at91_ebi_dev_disable(struct at91_ebi *ebi, struct > > device_node *np) { > > @@ -764,8 +763,4 @@ static struct platform_driver at91_ebi_driver = > > { .of_match_table = at91_ebi_id_table, > > }, > > }; > > -module_platform_driver_probe(at91_ebi_driver, at91_ebi_probe); > > - > > -MODULE_AUTHOR("Jean-Jacques Hiblot "); > > -MODULE_DESCRIPTION("Atmel EBI driver"); > > -MODULE_LICENSE("GPL"); > > +builtin_platform_driver_probe(at91_ebi_driver, at91_ebi_probe); > > > >