From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755048AbcFQO2V (ORCPT <rfc822;w@1wt.eu>);
	Fri, 17 Jun 2016 10:28:21 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:50881 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752355AbcFQO2T (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 17 Jun 2016 10:28:19 -0400
Date: Fri, 17 Jun 2016 16:28:14 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Yuyang Du <yuyang.du@intel.com>, Ingo Molnar <mingo@kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Mike Galbraith <umgwanakikbuti@gmail.com>,
        Benjamin Segall <bsegall@google.com>, Paul Turner <pjt@google.com>,
        Morten Rasmussen <morten.rasmussen@arm.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Matt Fleming <matt@codeblueprint.co.uk>
Subject: Re: [PATCH 4/4] sched,fair: Fix PELT integrity for new tasks
Message-ID: <20160617142814.GT30154@twins.programming.kicks-ass.net>
References: <20160617120136.064100812@infradead.org>
 <20160617120454.150630859@infradead.org>
 <CAKfTPtAUtteP0V5-1u2n0YFDdFbZfwSqigHjOfM32Vbw3iAPbg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAKfTPtAUtteP0V5-1u2n0YFDdFbZfwSqigHjOfM32Vbw3iAPbg@mail.gmail.com>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 17, 2016 at 04:09:01PM +0200, Vincent Guittot wrote:
> >
> > Scenario 1: switch to fair class
> >
> >   p->sched_class = fair_class;
> >   if (queued)
> >     enqueue_task(p);
> >       ...
> >         enqueue_entity()
> >           enqueue_entity_load_avg()
> >             migrated = !sa->last_update_time (true)
> >             if (migrated)
> >               attach_entity_load_avg()
> >   check_class_changed()
> >     switched_from() (!fair)
> >     switched_to()   (fair)
> >       switched_to_fair()
> >         attach_entity_load_avg()

> > @@ -733,18 +737,21 @@ void post_init_entity_util_avg(struct sc
> >                 }
> >                 sa->util_sum = sa->util_avg * LOAD_AVG_MAX;
> >         }
> > +
> > +       update_cfs_rq_load_avg(cfs_rq_clock_task(cfs_rq), cfs_rq, false);
> > +       attach_entity_load_avg(cfs_rq, se);
> 
> A new RT task will be attached and will contribute to the load until
> it decays to 0
> Should we detach it for non cfs task ? We just want to update
> last_update_time of RT task to something different from 0

Won't we open up that (scenario 1) hole again? Maybe we can initialize
!fair tasks to 0 load and have them ramp up once they get demoted back
to fair?

Blergh, I'll go ponder moar.