From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755727AbcFQQLD (ORCPT ); Fri, 17 Jun 2016 12:11:03 -0400 Received: from mail-yw0-f194.google.com ([209.85.161.194]:35470 "EHLO mail-yw0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753942AbcFQQLA (ORCPT ); Fri, 17 Jun 2016 12:11:00 -0400 Date: Fri, 17 Jun 2016 12:10:53 -0400 From: Tejun Heo To: Arnd Bergmann Cc: y2038@lists.linaro.org, linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ata: fix "ering" sysfs time printing Message-ID: <20160617161053.GK3262@mtj.duckdns.org> References: <20160617153739.429055-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160617153739.429055-1-arnd@arndb.de> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 17, 2016 at 05:37:12PM +0200, Arnd Bergmann wrote: > The sysfs file for the libata error handling has multiple issues > in the way it prints time stamps: > > * it prints a 9-digit nanosecond value using a %06lu format string, > which drops some leading zeroes > * it converts a 64-bit jiffes value to a timespec using > jiffies_to_timespec(), which takes a 'long' argument, so the > result is wrong after a jiffies overflow (49 days). > * we try to avoid using timespec because that generally overflows > in 2038, although this particular usage is ok. > > This replaces the jiffies_to_timespec call with an open-coded > implementation that gets it right. > > Signed-off-by: Arnd Bergmann Heh, I'm not even sure why we're exposing this but it's already there. Applied to libata/for-4.8. Thanks! -- tejun