mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Omar Sandoval <osandov@osandov.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
	Ingo Molnar <mingo@redhat.com>, Namhyung Kim <namhyung@gmail.com>,
	linux-kernel@vger.kernel.org, kernel-team@fb.com,
	Alexei Starovoitov <ast@fb.com>
Subject: Re: [PATCH v3] tracing: expose current->comm to [ku]probe events
Date: Fri, 17 Jun 2016 10:52:51 -0700	[thread overview]
Message-ID: <20160617175251.GB28716@vader.DHCP.thefacebook.com> (raw)
In-Reply-To: <20160617121927.7ed10a76@gandalf.local.home>

On Fri, Jun 17, 2016 at 12:19:27PM -0400, Steven Rostedt wrote:
> On Thu, 9 Jun 2016 11:55:34 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
> 
> > On Wed,  8 Jun 2016 18:38:02 -0700
> > Omar Sandoval <osandov@osandov.com> wrote:
> > 
> > > From: Omar Sandoval <osandov@fb.com>
> > > 
> > > ftrace is very quick to give up on saving the task command line (see
> > > `trace_save_cmdline()`). The workaround for events which really care
> > > about the command line is to explicitly assign it as part of the entry.
> > > However, this doesn't work for kprobe events, as there's no
> > > straightforward way to get access to current->comm. Add a kprobe/uprobe
> > > event variable $comm which provides exactly that.
> > > 
> > > Signed-off-by: Omar Sandoval <osandov@fb.com>  
> > 
> > Looks good to me:)
> > 
> > Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
> > 
> > > ---
> > > Alexei pointed out to me that this same functionality can be acheived
> > > with BPF and the bpf_get_current_comm() helper, so strictly speaking,
> > > this patch isn't necessary. It's still convenient for ad-hoc stuff,
> > > though, so I figured I'd throw this up and see what everyone thought.  
> > 
> > Anyway, I'd like to pull this patch since this still be useful
> > in handy way to get comm on ftrace :)
> > 
> 
> I pulled it.
> 
> Thanks!
> 
> -- Steve

Thanks, Steve!

-- 
Omar

      reply	other threads:[~2016-06-17 17:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-09  1:38 Omar Sandoval
2016-06-09  2:55 ` Masami Hiramatsu
2016-06-17 16:19   ` Steven Rostedt
2016-06-17 17:52     ` Omar Sandoval [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160617175251.GB28716@vader.DHCP.thefacebook.com \
    --to=osandov@osandov.com \
    --cc=ast@fb.com \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@gmail.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®