From: David Miller <davem@davemloft.net>
To: matorola@gmail.com
Cc: mroos@linux.ee, sparclinux@vger.kernel.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: 4.6-rc*: Kernel unaligned access at pci_bus_read_config_dword+0x64/0x80
Date: Sat, 18 Jun 2016 23:49:08 -0700 (PDT) [thread overview]
Message-ID: <20160618.234908.1671877676732375612.davem@davemloft.net> (raw)
In-Reply-To: <20160618.210421.1400395696678491125.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Sat, 18 Jun 2016 21:04:21 -0700 (PDT)
> From: Anatoly Pugachev <matorola@gmail.com>
> Date: Thu, 16 Jun 2016 13:02:07 +0300
>
>> bisected to git commit 63e3027
>
> That's a merge commit that adds 100 different commits, and this happened
> way back in March.
>
> Please find the exact dword access in:
>
> drivers/pci/pcie/portdrv_{core,pci,bus}.c
>
> that triggers this unaligned access so we can debug this further.
Meanwhile I figured it out, this should fix the bug:
diff --git a/drivers/pci/vc.c b/drivers/pci/vc.c
index dfbab61..1fa3a32 100644
--- a/drivers/pci/vc.c
+++ b/drivers/pci/vc.c
@@ -221,9 +221,9 @@ static int pci_vc_do_save_buffer(struct pci_dev *dev, int pos,
else
pci_write_config_word(dev, pos + PCI_VC_PORT_CTRL,
*(u16 *)buf);
- buf += 2;
+ buf += 4;
}
- len += 2;
+ len += 4;
/*
* If we have any Low Priority VCs and a VC Arbitration Table Offset
next prev parent reply other threads:[~2016-06-19 6:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 19:11 Meelis Roos
2016-06-09 17:33 ` Anatoly Pugachev
2016-06-13 12:49 ` Meelis Roos
2016-06-14 13:02 ` Anatoly Pugachev
2016-06-14 22:38 ` Anatoly Pugachev
2016-06-16 10:02 ` Anatoly Pugachev
2016-06-19 4:04 ` David Miller
2016-06-19 6:49 ` David Miller [this message]
2016-06-19 11:42 ` mroos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160618.234908.1671877676732375612.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matorola@gmail.com \
--cc=mroos@linux.ee \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®