mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@savoirfairelinux.com,
	"David S. Miller" <davem@davemloft.net>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Ben Dooks <ben.dooks@codethink.co.uk>,
	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH v3 net-next v3 13/14] net: dsa: mv88e6xxx: add addressing mode to info
Date: Sat, 18 Jun 2016 22:36:39 +0200	[thread overview]
Message-ID: <20160618203639.GH7172@lunn.ch> (raw)
In-Reply-To: <20160618000736.5598-14-vivien.didelot@savoirfairelinux.com>

> +struct mv88e6xxx_smi_ops {
> +	int (*read)(struct mii_bus *bus, int sw_addr,
> +		    int addr, int reg, u16 *val);
> +	int (*write)(struct mii_bus *bus, int sw_addr,
> +		     int addr, int reg, u16 val);
> +};

Hi Vivien

I still think this API should be based on ps.

With the way you have restructured probe, this now also works, there
is no longer a read without PS in order to get the device ID.

Also, think about the case of reading/writing registers via Ethernet
frames. Such functions would need ps, bus and sw_addr is not useful.

	Andrew

  reply	other threads:[~2016-06-18 20:36 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-18  0:07 [PATCH v3 net-next v3 00/14] net: dsa: mv88e6xxx: probe compatible Vivien Didelot
2016-06-18  0:07 ` [PATCH v3 net-next v3 01/14] net: dsa: mv88e6xxx: fix style issues Vivien Didelot
2016-06-18  0:07 ` [PATCH v3 net-next v3 02/14] net: dsa: mv88e6xxx: remove redundant assignments Vivien Didelot
2016-06-18  0:07 ` [PATCH v3 net-next v3 03/14] net: dsa: mv88e6xxx: use already declared variables Vivien Didelot
2016-06-18  0:07 ` [PATCH v3 net-next v3 04/14] net: dsa: mv88e6xxx: do not increment bus refcount Vivien Didelot
2016-06-18  0:07 ` [PATCH v3 net-next v3 05/14] net: dsa: mv88e6xxx: add switch register helpers Vivien Didelot
2016-06-18  0:07 ` [PATCH v3 net-next v3 06/14] net: dsa: mv88e6xxx: use gpio get optional variant Vivien Didelot
2016-06-18 20:17   ` Andrew Lunn
2016-06-18  0:07 ` [PATCH v3 net-next v3 07/14] net: dsa: mv88e6xxx: remove table args in info lookup Vivien Didelot
2016-06-18 20:18   ` Andrew Lunn
2016-06-18  0:07 ` [PATCH v3 net-next v3 08/14] net: dsa: mv88e6xxx: rename smi_mutex to reg_lock Vivien Didelot
2016-06-18 20:20   ` Andrew Lunn
2016-06-18  0:07 ` [PATCH v3 net-next v3 09/14] net: dsa: mv88e6xxx: add chip allocation helper Vivien Didelot
2016-06-18 20:22   ` Andrew Lunn
2016-06-18  0:07 ` [PATCH v3 net-next v3 10/14] net: dsa: mv88e6xxx: add SMI init helper Vivien Didelot
2016-06-18 20:25   ` Andrew Lunn
2016-06-18  0:07 ` [PATCH v3 net-next v3 11/14] net: dsa: mv88e6xxx: add detection helper Vivien Didelot
2016-06-18 20:27   ` Andrew Lunn
2016-06-18  0:07 ` [PATCH v3 net-next v3 12/14] net: dsa: mv88e6xxx: pass compatible info Vivien Didelot
2016-06-18 20:28   ` Andrew Lunn
2016-06-18  0:07 ` [PATCH v3 net-next v3 13/14] net: dsa: mv88e6xxx: add addressing mode to info Vivien Didelot
2016-06-18 20:36   ` Andrew Lunn [this message]
2016-06-18 21:18     ` Vivien Didelot
2016-06-18  0:07 ` [PATCH v3 net-next v3 14/14] net: dsa: mv88e6xxx: add port base address " Vivien Didelot
2016-06-18 20:38   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160618203639.GH7172@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=ben.dooks@codethink.co.uk \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=kernel@savoirfairelinux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®