From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751564AbcFSPzk (ORCPT ); Sun, 19 Jun 2016 11:55:40 -0400 Received: from mx2.suse.de ([195.135.220.15]:33731 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750907AbcFSPyx (ORCPT ); Sun, 19 Jun 2016 11:54:53 -0400 Date: Sun, 19 Jun 2016 17:53:47 +0200 From: Jan Kara To: Arnd Bergmann Cc: "Theodore Ts'o" , Jan Kara , y2038@lists.linaro.org, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] jbd2: make journal y2038 safe Message-ID: <20160619155347.GB2734@quack2.suse.cz> References: <20160617153916.444842-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160617153916.444842-1-arnd@arndb.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 17-06-16 17:39:00, Arnd Bergmann wrote: > The jbd2 journal stores the commit time in 64-bit seconds and 32-bit > nanoseconds, which avoids an overflow in 2038, but it gets the numbers > from current_kernel_time(), which uses 'long' seconds on 32-bit > architectures. > > This simply changes the code to call current_kernel_time64() so > we use 64-bit seconds consistently. > > Signed-off-by: Arnd Bergmann The patch looks good. You can add: Reviewed-by: Jan Kara Honza > --- > fs/jbd2/commit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/jbd2/commit.c b/fs/jbd2/commit.c > index 8f7d1339c973..5bb565f9989c 100644 > --- a/fs/jbd2/commit.c > +++ b/fs/jbd2/commit.c > @@ -124,7 +124,7 @@ static int journal_submit_commit_record(journal_t *journal, > struct commit_header *tmp; > struct buffer_head *bh; > int ret; > - struct timespec now = current_kernel_time(); > + struct timespec64 now = current_kernel_time64(); > > *cbh = NULL; > > -- > 2.9.0 > -- Jan Kara SUSE Labs, CR