From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754148AbcFTOh2 (ORCPT ); Mon, 20 Jun 2016 10:37:28 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36779 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751881AbcFTOhR (ORCPT ); Mon, 20 Jun 2016 10:37:17 -0400 Date: Mon, 20 Jun 2016 16:35:39 +0200 From: Michal Hocko To: YOSHIDA Masanori Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, mgorman@techsingularity.net, vbabka@suse.cz, rientjes@google.com, iamjoonsoo.kim@lge.com, izumi.taku@jp.fujitsu.com, hannes@cmpxchg.org, linux-mm@kvack.org, YOSHIDA Masanori Subject: Re: [PATCH] Delete meaningless check of current_order in __rmqueue_fallback Message-ID: <20160620143539.GG9892@dhcp22.suse.cz> References: <1465754611-21398-1-git-send-email-masanori.yoshida.lkml@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465754611-21398-1-git-send-email-masanori.yoshida.lkml@gmail.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 13-06-16 03:03:31, YOSHIDA Masanori wrote: > From: YOSHIDA Masanori > > Signed-off-by: YOSHIDA Masanori > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 6903b69..db02967 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -2105,7 +2105,7 @@ __rmqueue_fallback(struct zone *zone, unsigned int order, int start_migratetype) > > /* Find the largest possible block of pages in the other list */ > for (current_order = MAX_ORDER-1; > - current_order >= order && current_order <= MAX_ORDER-1; > + current_order >= order; > --current_order) { > area = &(zone->free_area[current_order]); > fallback_mt = find_suitable_fallback(area, current_order, This is incorrect. Guess what happens if the given order is 0. Hint, current_order is unsigned int. -- Michal Hocko SUSE Labs