From: Tejun Heo <tj@kernel.org>
To: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Cc: David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtip32xx: Remove deprecated create_workqueue
Date: Mon, 20 Jun 2016 11:05:10 -0400 [thread overview]
Message-ID: <20160620150510.GV3262@mtj.duckdns.org> (raw)
In-Reply-To: <20160620150144.GU3262@mtj.duckdns.org>
On Mon, Jun 20, 2016 at 11:01:44AM -0400, Tejun Heo wrote:
> On Sat, Jun 18, 2016 at 01:52:05PM +0530, Bhaktipriya Shridhar wrote:
> > alloc_workqueue replaces deprecated create_workqueue().
> >
> > A dedicated workqueue has been used since the workqueue isr_workq is
> > involved in irq handling path of block driver and requires forward
> > progress under memory pressure. Hence, WQ_MEM_RECLAIM has been set.
> > Since there are only a fixed number of work items, explicit concurrency
> > limit is unnecessary here.
> >
> > flush_workqueue is unnecessary since destroy_workqueue() itself calls
> > drain_workqueue() which flushes repeatedly till the workqueue
> > becomes empty. Hence the calls to flush_workqueue() before
> > destroy_workqueue() have been dropped.
>
> Looks good.
lol thought this was a private review exchange. Sorry about that.
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
prev parent reply other threads:[~2016-06-20 15:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-18 8:22 Bhaktipriya Shridhar
2016-06-20 15:01 ` Tejun Heo
2016-06-20 15:05 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620150510.GV3262@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=airlied@linux.ie \
--cc=bhaktipriya96@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®