From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755220AbcFTQHT (ORCPT ); Mon, 20 Jun 2016 12:07:19 -0400 Received: from mail.savoirfairelinux.com ([208.88.110.44]:45639 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754603AbcFTQE7 (ORCPT ); Mon, 20 Jun 2016 12:04:59 -0400 From: Vivien Didelot To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Andrew Lunn , Florian Fainelli , Ben Dooks , Sergei Shtylyov , Vivien Didelot Subject: [PATCH v4 net-next v4 02/14] net: dsa: mv88e6xxx: remove redundant assignments Date: Mon, 20 Jun 2016 12:03:25 -0400 Message-Id: <20160620160337.2934-3-vivien.didelot@savoirfairelinux.com> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20160620160337.2934-1-vivien.didelot@savoirfairelinux.com> References: <20160620160337.2934-1-vivien.didelot@savoirfairelinux.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The chip->ds and ds->slave_mii_bus assignments are common to both legacy and new MDIO probing and are already done in the later setup code. Remove the duplicated assignments from the MDIO probing code. Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c index 1972ec5..673283a 100644 --- a/drivers/net/dsa/mv88e6xxx.c +++ b/drivers/net/dsa/mv88e6xxx.c @@ -3708,7 +3708,6 @@ static int mv88e6xxx_probe(struct mdio_device *mdiodev) ds->priv = ps; ds->dev = dev; ps->dev = dev; - ps->ds = ds; ps->bus = mdiodev->bus; ps->sw_addr = mdiodev->addr; mutex_init(&ps->smi_mutex); @@ -3748,8 +3747,6 @@ static int mv88e6xxx_probe(struct mdio_device *mdiodev) if (err) return err; - ds->slave_mii_bus = ps->mdio_bus; - dev_set_drvdata(dev, ds); err = dsa_register_switch(ds, mdiodev->dev.of_node); -- 2.9.0