From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: SeongJae Park <sj38.park@gmail.com>
Cc: josh@joshtriplett.org, corbet@lwn.net,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH] rcutorture: Remove outdated config option description
Date: Mon, 20 Jun 2016 10:39:36 -0700 [thread overview]
Message-ID: <20160620173936.GU3923@linux.vnet.ibm.com> (raw)
In-Reply-To: <1466376682-31378-1-git-send-email-sj38.park@gmail.com>
On Mon, Jun 20, 2016 at 07:51:22AM +0900, SeongJae Park wrote:
> CONFIG_RCU_TORTURE_TEST_RUNNABLE has removed by commit 4e9a073f60367
> ("torture: Remove CONFIG_RCU_TORTURE_TEST_RUNNABLE, simplify code")
> entirely but the document has not updated. This commit updates the
> document to remove the description for the config option and adding a
> description for the alternative module parameter.
>
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
Good catch on CONFIG_RCU_TORTURE_TEST_RUNNABLE, queued for testing and
review.
I had to drop the other hunk for torture_runnable, though. This
capability is instead controlled by several parameters that are documented
in Documentation/kernel-parameters.txt.
Thanx, Paul
> ---
> Documentation/RCU/torture.txt | 20 +++++---------------
> 1 file changed, 5 insertions(+), 15 deletions(-)
>
> diff --git a/Documentation/RCU/torture.txt b/Documentation/RCU/torture.txt
> index 118e7c1..4bd9d86 100644
> --- a/Documentation/RCU/torture.txt
> +++ b/Documentation/RCU/torture.txt
> @@ -10,21 +10,6 @@ status messages via printk(), which can be examined via the dmesg
> command (perhaps grepping for "torture"). The test is started
> when the module is loaded, and stops when the module is unloaded.
>
> -CONFIG_RCU_TORTURE_TEST_RUNNABLE
> -
> -It is also possible to specify CONFIG_RCU_TORTURE_TEST=y, which will
> -result in the tests being loaded into the base kernel. In this case,
> -the CONFIG_RCU_TORTURE_TEST_RUNNABLE config option is used to specify
> -whether the RCU torture tests are to be started immediately during
> -boot or whether the /proc/sys/kernel/rcutorture_runnable file is used
> -to enable them. This /proc file can be used to repeatedly pause and
> -restart the tests, regardless of the initial state specified by the
> -CONFIG_RCU_TORTURE_TEST_RUNNABLE config option.
> -
> -You will normally -not- want to start the RCU torture tests during boot
> -(and thus the default is CONFIG_RCU_TORTURE_TEST_RUNNABLE=n), but doing
> -this can sometimes be useful in finding boot-time bugs.
> -
>
> MODULE PARAMETERS
>
> @@ -164,6 +149,11 @@ test_no_idle_hz Whether or not to test the ability of RCU to operate in
> idle CPUs. Boolean parameter, "1" to test, "0" otherwise.
> Defaults to omitting this test.
>
> +torture_runnable Start rcutorture at boot time in the case where the
> + module is built into the kernel, otherwise wait for
> + torture_runnable to be set via sysfs before starting.
> + By default it will begin once the module is loaded.
> +
> torture_type The type of RCU to test, with string values as follows:
>
> "rcu": rcu_read_lock(), rcu_read_unlock() and call_rcu(),
> --
> 1.9.1
>
prev parent reply other threads:[~2016-06-20 20:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-19 22:51 SeongJae Park
2016-06-20 17:39 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620173936.GU3923@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=corbet@lwn.net \
--cc=josh@joshtriplett.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sj38.park@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome