From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932943AbcFTVTE (ORCPT ); Mon, 20 Jun 2016 17:19:04 -0400 Received: from mail-pf0-f176.google.com ([209.85.192.176]:35359 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932706AbcFTVSv convert rfc822-to-8bit (ORCPT ); Mon, 20 Jun 2016 17:18:51 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Daniel Lezcano , daniel.lezcano@linaro.org, tglx@linutronix.de From: Michael Turquette In-Reply-To: <1464903697-3802-1-git-send-email-daniel.lezcano@linaro.org> Cc: linux-kernel@vger.kernel.org, "Russell King" , "open list:CLK API" References: <1464903697-3802-1-git-send-email-daniel.lezcano@linaro.org> Message-ID: <20160620211849.24587.73336@quark.deferred.io> User-Agent: alot/0.3.7 Subject: Re: [PATCH 1/6] clk: Add missing clk_get_sys() stub Date: Mon, 20 Jun 2016 14:18:49 -0700 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, Quoting Daniel Lezcano (2016-06-02 14:41:32) > When compiling with the COMPILE_TEST option set, the clps711x does not > compile because of the clk_get_sys() noop stub missing. > > Signed-off-by: Daniel Lezcano This looks OK to me. Russell maintains clkdev and the clk.h stuff, so it would be good to get his ack. Please feel free to add: Reviewed-by: Michael Turquette Regards, Mike > --- > include/linux/clk.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/linux/clk.h b/include/linux/clk.h > index 0df4a51..834179f 100644 > --- a/include/linux/clk.h > +++ b/include/linux/clk.h > @@ -461,6 +461,10 @@ static inline struct clk *clk_get_parent(struct clk *clk) > return NULL; > } > > +static inline struct clk *clk_get_sys(const char *dev_id, const char *con_id) > +{ > + return NULL; > +} > #endif > > /* clk_prepare_enable helps cases using clk_enable in non-atomic context. */ > -- > 1.9.1 >