From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753356AbcFTWng (ORCPT ); Mon, 20 Jun 2016 18:43:36 -0400 Received: from violet.fr.zoreil.com ([92.243.8.30]:36637 "EHLO violet.fr.zoreil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751628AbcFTWn3 (ORCPT ); Mon, 20 Jun 2016 18:43:29 -0400 Date: Tue, 21 Jun 2016 00:43:16 +0200 From: Francois Romieu To: Netanel Belgazal Cc: netdev@vger.kernel.org, davem@davemloft.net, linux-kernel@vger.kernel.org, zorik@annapurnalabs.com, saeed@annapurnalabs.com, alex@annapurnalabs.com, msw@amazon.com, aligouri@amazon.com, antoine.tenart@free-electrons.com Subject: Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) Message-ID: <20160620224316.GA11834@electric-eye.fr.zoreil.com> References: <1465807573-11293-1-git-send-email-netanel@annapurnalabs.com> <20160617211118.GA14822@electric-eye.fr.zoreil.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Organisation: Land of Sunshine Inc. User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Netanel Belgazal : [...] > > diff --git a/drivers/net/ethernet/amazon/ena/ena_com.h b/drivers/net/ethernet/amazon/ena/ena_com.h > > new file mode 100644 > > index 0000000..e49ba43 > > --- /dev/null > > [...] > > +static inline void ena_com_update_intr_reg(struct ena_eth_io_intr_reg *intr_reg, > > + u32 rx_delay_interval, > > + u32 tx_delay_interval, > > + bool unmask) > > +{ > > + intr_reg->intr_control = 0; > > + intr_reg->intr_control |= rx_delay_interval & > > + ENA_ETH_IO_INTR_REG_RX_INTR_DELAY_MASK; > > + > > + intr_reg->intr_control |= > > + (tx_delay_interval << ENA_ETH_IO_INTR_REG_TX_INTR_DELAY_SHIFT) > > + & ENA_ETH_IO_INTR_REG_RX_INTR_DELAY_MASK; > > ^^ TX ? > > > > Extra: you should not return NETDEV_TX_BUSY in the xmit handler while > > queueing is still enabled. Please drop packet and return NETDEV_TX_OK. > Ack. > > Thanks for your review. Ack/nack regarding use of ..._RX_INTR_DELAY_MASK with ..._TX_INTR_DELAY_SHIFT ? -- Ueimor