From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752799AbcFUIkv (ORCPT <rfc822;w@1wt.eu>);
	Tue, 21 Jun 2016 04:40:51 -0400
Received: from merlin.infradead.org ([205.233.59.134]:45203 "EHLO
	merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752765AbcFUIko (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 21 Jun 2016 04:40:44 -0400
Date: Tue, 21 Jun 2016 10:09:51 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        James Hartsock <hartsjc@redhat.com>, Rik van Riel <riel@redhat.com>,
        Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
        Kirill Tkhai <ktkhai@parallels.com>
Subject: Re: [PATCH 1/4] sched/fair: Introduce sched_entity::dont_balance
Message-ID: <20160621080951.GN30909@twins.programming.kicks-ass.net>
References: <1466424914-8981-1-git-send-email-jolsa@kernel.org>
 <1466424914-8981-2-git-send-email-jolsa@kernel.org>
 <20160620142823.GH30154@twins.programming.kicks-ass.net>
 <20160620155929.GA10167@krava>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160620155929.GA10167@krava>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 20, 2016 at 05:59:29PM +0200, Jiri Olsa wrote:
> On Mon, Jun 20, 2016 at 04:28:23PM +0200, Peter Zijlstra wrote:

> > Never use bool in structures.
> 
> ok, but I couldn't find anything real sinister about that..
> so why is that? ;-)

C does not define sizeof(bool) :-)

Obviously any implementation must, but you then get implementation
defined layout differences in your structures, which is crap.