mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Thomas Rowland <trowland2000@gmail.com>
Cc: kbuild-all@01.org, aar@pengutronix.de, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Thomas Rowland <trowland2000@gmail.com>
Subject: Re: [PATCH] include: net: cfg802154: rename ieee802154_llsec_device.hwaddr to extended_addr
Date: Tue, 21 Jun 2016 19:27:24 +0800	[thread overview]
Message-ID: <201606211914.DwZzhcfG%fengguang.wu@intel.com> (raw)
In-Reply-To: <1466504548-2958-1-git-send-email-trowland2000@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 7815 bytes --]

Hi,

[auto build test ERROR on net-next/master]
[also build test ERROR on v4.7-rc4 next-20160621]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Thomas-Rowland/include-net-cfg802154-rename-ieee802154_llsec_device-hwaddr-to-extended_addr/20160621-182617
config: x86_64-allyesdebian (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   net/ieee802154/nl-mac.c: In function 'llsec_parse_dev':
>> net/ieee802154/nl-mac.c:1003:5: error: 'struct ieee802154_llsec_device' has no member named 'hwaddr'; did you mean 'short_addr'?
     dev->hwaddr = nla_get_hwaddr(info->attrs[IEEE802154_ATTR_HW_ADDR]);
        ^~
   net/ieee802154/nl-mac.c: In function 'ieee802154_nl_fill_dev':
>> net/ieee802154/nl-mac.c:1069:55: error: 'const struct ieee802154_llsec_device' has no member named 'hwaddr'; did you mean 'short_addr'?
         nla_put_hwaddr(msg, IEEE802154_ATTR_HW_ADDR, desc->hwaddr,
                                                          ^~
   net/ieee802154/nl-mac.c: In function 'llsec_iter_devkeys':
   net/ieee802154/nl-mac.c:1208:17: error: 'struct ieee802154_llsec_device' has no member named 'hwaddr'; did you mean 'short_addr'?
                dpos->hwaddr, kpos,
                    ^~

vim +1003 net/ieee802154/nl-mac.c

3e9c156e Phoebe Buckheister 2014-05-16   997  		dev->pan_id = nla_get_shortaddr(info->attrs[IEEE802154_ATTR_PAN_ID]);
3e9c156e Phoebe Buckheister 2014-05-16   998  		dev->short_addr = nla_get_shortaddr(info->attrs[IEEE802154_ATTR_SHORT_ADDR]);
3e9c156e Phoebe Buckheister 2014-05-16   999  	} else {
3e9c156e Phoebe Buckheister 2014-05-16  1000  		dev->short_addr = cpu_to_le16(IEEE802154_ADDR_UNDEF);
3e9c156e Phoebe Buckheister 2014-05-16  1001  	}
3e9c156e Phoebe Buckheister 2014-05-16  1002  
3e9c156e Phoebe Buckheister 2014-05-16 @1003  	dev->hwaddr = nla_get_hwaddr(info->attrs[IEEE802154_ATTR_HW_ADDR]);
3e9c156e Phoebe Buckheister 2014-05-16  1004  	dev->frame_counter = nla_get_u32(info->attrs[IEEE802154_ATTR_LLSEC_FRAME_COUNTER]);
3e9c156e Phoebe Buckheister 2014-05-16  1005  	dev->seclevel_exempt = !!nla_get_u8(info->attrs[IEEE802154_ATTR_LLSEC_DEV_OVERRIDE]);
3e9c156e Phoebe Buckheister 2014-05-16  1006  	dev->key_mode = nla_get_u8(info->attrs[IEEE802154_ATTR_LLSEC_DEV_KEY_MODE]);
3e9c156e Phoebe Buckheister 2014-05-16  1007  
3e9c156e Phoebe Buckheister 2014-05-16  1008  	if (dev->key_mode >= __IEEE802154_LLSEC_DEVKEY_MAX)
3e9c156e Phoebe Buckheister 2014-05-16  1009  		return -EINVAL;
3e9c156e Phoebe Buckheister 2014-05-16  1010  
3e9c156e Phoebe Buckheister 2014-05-16  1011  	return 0;
3e9c156e Phoebe Buckheister 2014-05-16  1012  }
3e9c156e Phoebe Buckheister 2014-05-16  1013  
3e9c156e Phoebe Buckheister 2014-05-16  1014  static int llsec_add_dev(struct net_device *dev, struct genl_info *info)
3e9c156e Phoebe Buckheister 2014-05-16  1015  {
3e9c156e Phoebe Buckheister 2014-05-16  1016  	struct ieee802154_mlme_ops *ops = ieee802154_mlme_ops(dev);
3e9c156e Phoebe Buckheister 2014-05-16  1017  	struct ieee802154_llsec_device desc;
3e9c156e Phoebe Buckheister 2014-05-16  1018  
3e9c156e Phoebe Buckheister 2014-05-16  1019  	if (llsec_parse_dev(info, &desc))
3e9c156e Phoebe Buckheister 2014-05-16  1020  		return -EINVAL;
3e9c156e Phoebe Buckheister 2014-05-16  1021  
3e9c156e Phoebe Buckheister 2014-05-16  1022  	return ops->llsec->add_dev(dev, &desc);
3e9c156e Phoebe Buckheister 2014-05-16  1023  }
3e9c156e Phoebe Buckheister 2014-05-16  1024  
3e9c156e Phoebe Buckheister 2014-05-16  1025  int ieee802154_llsec_add_dev(struct sk_buff *skb, struct genl_info *info)
3e9c156e Phoebe Buckheister 2014-05-16  1026  {
3e9c156e Phoebe Buckheister 2014-05-16  1027  	if ((info->nlhdr->nlmsg_flags & (NLM_F_CREATE | NLM_F_EXCL)) !=
3e9c156e Phoebe Buckheister 2014-05-16  1028  	    (NLM_F_CREATE | NLM_F_EXCL))
3e9c156e Phoebe Buckheister 2014-05-16  1029  		return -EINVAL;
3e9c156e Phoebe Buckheister 2014-05-16  1030  
3e9c156e Phoebe Buckheister 2014-05-16  1031  	return ieee802154_nl_llsec_change(skb, info, llsec_add_dev);
3e9c156e Phoebe Buckheister 2014-05-16  1032  }
3e9c156e Phoebe Buckheister 2014-05-16  1033  
3e9c156e Phoebe Buckheister 2014-05-16  1034  static int llsec_del_dev(struct net_device *dev, struct genl_info *info)
3e9c156e Phoebe Buckheister 2014-05-16  1035  {
3e9c156e Phoebe Buckheister 2014-05-16  1036  	struct ieee802154_mlme_ops *ops = ieee802154_mlme_ops(dev);
3e9c156e Phoebe Buckheister 2014-05-16  1037  	__le64 devaddr;
3e9c156e Phoebe Buckheister 2014-05-16  1038  
3e9c156e Phoebe Buckheister 2014-05-16  1039  	if (!info->attrs[IEEE802154_ATTR_HW_ADDR])
3e9c156e Phoebe Buckheister 2014-05-16  1040  		return -EINVAL;
3e9c156e Phoebe Buckheister 2014-05-16  1041  
3e9c156e Phoebe Buckheister 2014-05-16  1042  	devaddr = nla_get_hwaddr(info->attrs[IEEE802154_ATTR_HW_ADDR]);
3e9c156e Phoebe Buckheister 2014-05-16  1043  
3e9c156e Phoebe Buckheister 2014-05-16  1044  	return ops->llsec->del_dev(dev, devaddr);
3e9c156e Phoebe Buckheister 2014-05-16  1045  }
3e9c156e Phoebe Buckheister 2014-05-16  1046  
3e9c156e Phoebe Buckheister 2014-05-16  1047  int ieee802154_llsec_del_dev(struct sk_buff *skb, struct genl_info *info)
3e9c156e Phoebe Buckheister 2014-05-16  1048  {
3e9c156e Phoebe Buckheister 2014-05-16  1049  	return ieee802154_nl_llsec_change(skb, info, llsec_del_dev);
3e9c156e Phoebe Buckheister 2014-05-16  1050  }
3e9c156e Phoebe Buckheister 2014-05-16  1051  
3e9c156e Phoebe Buckheister 2014-05-16  1052  static int
3e9c156e Phoebe Buckheister 2014-05-16  1053  ieee802154_nl_fill_dev(struct sk_buff *msg, u32 portid, u32 seq,
3e9c156e Phoebe Buckheister 2014-05-16  1054  		       const struct ieee802154_llsec_device *desc,
3e9c156e Phoebe Buckheister 2014-05-16  1055  		       const struct net_device *dev)
3e9c156e Phoebe Buckheister 2014-05-16  1056  {
3e9c156e Phoebe Buckheister 2014-05-16  1057  	void *hdr;
3e9c156e Phoebe Buckheister 2014-05-16  1058  
3e9c156e Phoebe Buckheister 2014-05-16  1059  	hdr = genlmsg_put(msg, 0, seq, &nl802154_family, NLM_F_MULTI,
3e9c156e Phoebe Buckheister 2014-05-16  1060  			  IEEE802154_LLSEC_LIST_DEV);
3e9c156e Phoebe Buckheister 2014-05-16  1061  	if (!hdr)
3e9c156e Phoebe Buckheister 2014-05-16  1062  		goto out;
3e9c156e Phoebe Buckheister 2014-05-16  1063  
3e9c156e Phoebe Buckheister 2014-05-16  1064  	if (nla_put_string(msg, IEEE802154_ATTR_DEV_NAME, dev->name) ||
3e9c156e Phoebe Buckheister 2014-05-16  1065  	    nla_put_u32(msg, IEEE802154_ATTR_DEV_INDEX, dev->ifindex) ||
3e9c156e Phoebe Buckheister 2014-05-16  1066  	    nla_put_shortaddr(msg, IEEE802154_ATTR_PAN_ID, desc->pan_id) ||
3e9c156e Phoebe Buckheister 2014-05-16  1067  	    nla_put_shortaddr(msg, IEEE802154_ATTR_SHORT_ADDR,
3e9c156e Phoebe Buckheister 2014-05-16  1068  			      desc->short_addr) ||
a558da09 Nicolas Dichtel    2016-04-25 @1069  	    nla_put_hwaddr(msg, IEEE802154_ATTR_HW_ADDR, desc->hwaddr,
a558da09 Nicolas Dichtel    2016-04-25  1070  			   IEEE802154_ATTR_PAD) ||
3e9c156e Phoebe Buckheister 2014-05-16  1071  	    nla_put_u32(msg, IEEE802154_ATTR_LLSEC_FRAME_COUNTER,
3e9c156e Phoebe Buckheister 2014-05-16  1072  			desc->frame_counter) ||

:::::: The code at line 1003 was first introduced by commit
:::::: 3e9c156e2c210ab67b12b1b692983a6b97c19d3f ieee802154: add netlink interfaces for llsec

:::::: TO: Phoebe Buckheister <phoebe.buckheister@itwm.fraunhofer.de>
:::::: CC: David S. Miller <davem@davemloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 37232 bytes --]

  parent reply	other threads:[~2016-06-21 11:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-21 10:22 Thomas Rowland
2016-06-21 10:49 ` kbuild test robot
2016-06-21 11:27 ` kbuild test robot [this message]
2016-06-21 11:29 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201606211914.DwZzhcfG%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=aar@pengutronix.de \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=trowland2000@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®