From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751738AbcFUWQl (ORCPT ); Tue, 21 Jun 2016 18:16:41 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:34895 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751099AbcFUWQj (ORCPT ); Tue, 21 Jun 2016 18:16:39 -0400 Date: Tue, 21 Jun 2016 16:58:42 -0500 From: Rob Herring To: Xing Zheng Cc: heiko@sntech.de, linux-rockchip@lists.infradead.org, roger.chen@rock-chips.com, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Giuseppe Cavallaro , Alexandre Torgue , "David S. Miller" , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2] net: stmmac: dwmac-rk: add rk3228-specific data Message-ID: <20160621215842.GA16151@rob-hp-laptop> References: <1466512409-18855-1-git-send-email-zhengxing@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466512409-18855-1-git-send-email-zhengxing@rock-chips.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 21, 2016 at 08:33:28PM +0800, Xing Zheng wrote: > Add constants and callback functions for the dwmac on rk3228/rk3229 socs. > As can be seen, the base structure is the same, only registers and the > bits in them moved slightly. > > Signed-off-by: Xing Zheng > --- > > Changes in v2: > - the "rk322x" is not clear to SoC decription, rename it to "rk3228" > > .../devicetree/bindings/net/rockchip-dwmac.txt | 3 +- > drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 117 ++++++++++++++++++++ > 2 files changed, 119 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.txt b/Documentation/devicetree/bindings/net/rockchip-dwmac.txt > index 93eac7c..cccd945 100644 > --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.txt > +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.txt > @@ -3,7 +3,8 @@ Rockchip SoC RK3288 10/100/1000 Ethernet driver(GMAC) > The device node has following properties. > > Required properties: > - - compatible: Can be one of "rockchip,rk3288-gmac", "rockchip,rk3368-gmac" > + - compatible: Can be one of "rockchip,rk3228-gmac", "rockchip,rk3288-gmac", > + "rockchip,rk3368-gmac" Not worth reposting just for this, but 1 per line is preferred. Acked-by: Rob Herring > - reg: addresses and length of the register sets for the device. > - interrupts: Should contain the GMAC interrupts. > - interrupt-names: Should contain the interrupt names "macirq".