From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752369AbcFVKQX (ORCPT ); Wed, 22 Jun 2016 06:16:23 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:58814 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752328AbcFVKQU (ORCPT ); Wed, 22 Jun 2016 06:16:20 -0400 Date: Wed, 22 Jun 2016 11:16:11 +0100 From: Mark Brown To: Keerthy Cc: Keerthy , tony@atomide.com, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, t-kristo@ti.com, russ.dill@ti.com, robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk Message-ID: <20160622101611.GI28202@sirena.org.uk> References: <1466412218-5906-1-git-send-email-j-keerthy@ti.com> <1466412218-5906-2-git-send-email-j-keerthy@ti.com> <20160621190848.GF28202@sirena.org.uk> <576A64EA.4000607@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Encpt1P6Mxii2VuT" Content-Disposition: inline In-Reply-To: <576A64EA.4000607@ti.com> X-Cookie: Beware of Bigfoot! User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/9] regulator: tps65217: Enable suspend configuration X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Encpt1P6Mxii2VuT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 22, 2016 at 03:44:02PM +0530, Keerthy wrote: > Hence saving it in a static array and using it later in the ops functions to > disable or enable regulator during suspend. Why a static array and not part of the dynamically allocated driver data? --Encpt1P6Mxii2VuT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXamVpAAoJECTWi3JdVIfQ2FEH/1KSem8eNAWDCdpOmy8v8jJe ixmSH+oUNIfKsXMPg8eVIVycXLX2lo7ez277dsxqWXZ8m6Dgi8OGrF0pAdsZhF2Y VOzn4F+7tcDHuJe6PmymHpMvj6Q7SSd6Kieda7Ic7mozFzYh8/OV5Mb9hfM/WO31 0hbJtVWzORTaEKWmSBI2k7kmTmPEM0Kwc4tFO8q2zeQ1Q8B2WczVYg2n3Mf+ZxDy h8/8fB7mflvPhg8KkOhUCiepJRkQJagDbdI+qZEgPD62WOBW49jLbvqAmlviDspx YuplJ5zc4u1LDmZfrPlETCfOpqLvQGYMlGeBQ9TAexQr+UdJSHrGhmsd5W7cTWI= =jzNr -----END PGP SIGNATURE----- --Encpt1P6Mxii2VuT--