From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752617AbcFVNHW (ORCPT <rfc822;w@1wt.eu>);
	Wed, 22 Jun 2016 09:07:22 -0400
Received: from foss.arm.com ([217.140.101.70]:47444 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751214AbcFVNHS (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 22 Jun 2016 09:07:18 -0400
Date: Wed, 22 Jun 2016 14:06:21 +0100
From: Mark Rutland <mark.rutland@arm.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Andy Gross <andy.gross@linaro.org>, devicetree@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        David Brown <david.brown@linaro.org>, Rob Herring <robh+dt@kernel.org>,
        linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/8] arm64: dts: db820c: add basic board support
Message-ID: <20160622130621.GB28950@leverpostej>
References: <1466529769-2674-1-git-send-email-srinivas.kandagatla@linaro.org>
 <1466529769-2674-2-git-send-email-srinivas.kandagatla@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1466529769-2674-2-git-send-email-srinivas.kandagatla@linaro.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 21, 2016 at 06:22:42PM +0100, Srinivas Kandagatla wrote:
> +	chosen {
> +		stdout-path = "serial0";
> +	};

Please add the configuration (e.g. make this "serial0:115200n8"), as per
Documentation/devicetree/bindings/chosen.txt, so that we're not relying
on implicit defaults.

Otherwise this looks ok.

Thanks,
Mark.