From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751594AbcFWHAv (ORCPT ); Thu, 23 Jun 2016 03:00:51 -0400 Received: from mail-db3on0086.outbound.protection.outlook.com ([157.55.234.86]:49408 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751078AbcFWHAt (ORCPT ); Thu, 23 Jun 2016 03:00:49 -0400 X-Greylist: delayed 4702 seconds by postgrey-1.27 at vger.kernel.org; Thu, 23 Jun 2016 03:00:48 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=leonro@mellanox.com; Date: Thu, 23 Jun 2016 08:27:01 +0300 From: Leon Romanovsky To: Saeed Mahameed , Joe Perches CC: Matan Barak , , , linux-kernel Subject: Re: [PATCH] mellanox: mlx5: Use logging functions to reduce text ~10k/5% Message-ID: <20160623052701.GB30933@leon.nu> References: <1466619839.13093.4.camel@perches.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="xgyAXRrhYN0wYx8y" Content-Disposition: inline In-Reply-To: <1466619839.13093.4.camel@perches.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [213.57.247.249] X-ClientProxiedBy: DB5PR10CA0028.EURPRD10.PROD.OUTLOOK.COM (10.165.4.166) To VI1PR0501MB1935.eurprd05.prod.outlook.com (10.166.44.150) X-MS-Office365-Filtering-Correlation-Id: 974bb83b-0014-496a-98a9-08d39b2704bf X-Microsoft-Exchange-Diagnostics: 1;VI1PR0501MB1935;2:67vJGxwmXFovlM1A8ipL/3cM9UpFPZxGcHlrFUmUI9KyLW6ujVXW0YvbhoU5yf5XKfP2ROFM6FnLpHZ9yqgvdEBdlfkFqh3ENSq1EjQnSKmIT8aIw2/T7eb0qeapVAuWHvGtasLW/6DB8X5wCUP6zfXHFSjtpssDEA2rcP2UOcGfbhXIOuHJWnXN8MbFYINH;3:/GtfgMzTaSTHy+YJfhNfklHEYmezt92kP1FvpSbAjY+SkuRpvPOUQRTNj13a+BbxEQ6+m3YNShHcBqKxkZn89OFlPamAkWGIN90rBbH6hlLZFt+K+WEoNuHwzWtKn9Ze X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0501MB1935; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0501MB1935;25:4bub3z3PUtRcuI5dOX65P5rYMFWjdtx5adh/Vrh1ZfgEPdkdHY4x9K07cx7ZA6xkzQtZ08e+HPpDN1yoakw9Ne8iF3LmmsBN9SaMV2tXxPgZcWFh0OfSs6uoXWKEOSH7BnE1JFeYa8qPJl5C8fOAI8an4+dTJabUg/2tBxCBKGSFmFsteug933e8TAHYX3ik0ZwhsqtqIr2CQ7FEw0R0dCu1pe36bHoggyOCiS4KEMfXHmNwgi+81BW6Wm5YX3zBGT5qo5VjLZPqNIjPKhtLQfhOIBQRvi5KMC+mgLN4sOVk66ubP6b/Ya1xKxvyXjMmRwtvtGbgbV/Cfwh+hdYrBqBqQvEO9x/j5VNQG+qKU0jC+DIije9J3EwH170q5iG2bO3dDI09BEReK7DaEIn+DXiir+UU7LowmnW0oUaM7PQclvRCdzNX0nB/+P+bnUOk7gl9kWlACIxHUHq18ibObl/gbIU6tvv39QltFcAJO9V2Y0R89jukB0zI28i13xuWbzFEBhzTViGnBKp38lp0L4AEkOiZ/lXUPBw07N0RmFaidoytTCtNZOS6pE55eeJ/STKOTpHLe9G2Bf8Eak3Z4vaJGBBF8tVG1w3jaLoIgOGJXyFwinnRh30B4sonywY6wR9V24Hr9dpLVkNr6/KQ+8MDjlBPWfr5tbf7L0M8AjShwGFhv/pKe871+womurYdfO+Vv6/mTfqRnNy/e53ByMWUbja4HAVDRPERaQVO5br5mQ7dIrZ8aj9Rf9K2wIJlCxHkzBRquRqu3pNXGdZzx1tAKbdZ/7EWmkIb27oYCG3UHteK+/KL06M24pgEx4NS X-Microsoft-Exchange-Diagnostics: 1;VI1PR0501MB1935;20:6e8kvAZUoBEZ4ze8iD2Xvon1UbUNINBc6vb56e0MRKqBnW7zsW3yIuKb0kCapsSJhcI1YZmO2zaZ6IPPacOklTb0BDAujoCDaMZxvaq5izjiWygOBoQJOMx1sUPZ1Z6bvJ5eafr3/SWcwSGehcoyrHxILvuLqfM/36o5XlL8mvyhBRs43cJPCMT9lxCTsm0Skv94mnpFFaGoE0GGnCs4CJJVyh9MFlYRw+Ql2BkSC7I4BP6ZOZHgGJVKScAFHNtHXmjZ9K65QKmxT8o406ODkUrhgPF7quC8GIVFArbbkd70bGJ6ASWcD4ScLkkqe2OAhljxMybNJr7MLwvkmjR12q4c5va9nxxWtp0+pmtXPYmfVLEKS/p72sqh/Ul2OGijnA5o3epUAstLWHxoo+Hai7VtMc+TqBa9P/UvbkmnCWEQVNfL8Of0Cow6RQH8/RdUvAOh4Ih5InZRjoPqf/W7PpUUpn072yLd+h1uswSpI8JM30iJyuv9RcvX1XT6f9el;4:QI/rroPg+T41/WHSS+zAiKnaDbD6TqhkcWecd6M27kMXyR2DJCsr0LWXWVNiGAreV9xdDv1X2mE4vfCjsQKD5CeB9FN8mBuu9kYMXBX36KkwJ+3HVwog7qQ3CQYSd4xLvUpf0iSemYD7QN3N3bGPtNFaGNUmNV+ri7QWIZDbHgearHl27il2U1MN+VNisCuoSHkSaA9KX81Il/rVSBWrVcLaPhxoT+Vq4X2ODu7Wt9vO6Wq8SPWPxB8vTbpFsly4kCfqWz/jqVq0jcFixjQWSbRhjPnZgpXrz0EhBmKb5si9qYMIEvUWbRgT1myRPo3zA0z55sB0R6S5pNzOrmDRl3GITb4pLI3o0t6UDc7k85M2PuWJ+a0CVQlknsdY6NjQR33EUDmi9kZpEUWYDIydIw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:VI1PR0501MB1935;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0501MB1935; X-Forefront-PRVS: 098291215C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(979002)(6069001)(6009001)(7916002)(189002)(199003)(24454002)(76104003)(2950100001)(5000100001)(77096005)(66066001)(86362001)(92566002)(3846002)(6116002)(1076002)(19580405001)(19580395003)(84326002)(586003)(83506001)(4326007)(2906002)(76506005)(21480400002)(42186005)(36756003)(4001350100001)(101416001)(106356001)(97736004)(33656002)(68736007)(189998001)(81166006)(81156014)(8676002)(76176999)(50986999)(305945005)(54356999)(9686002)(105586002)(5001770100001)(7846002)(7736002)(512934002)(2700100001)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0501MB1935;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;VI1PR0501MB1935;23:hpPOzeeFZtvWBfNTNFixTFMBcNw04nJ3SgQWa?= =?iso-8859-1?Q?4Dtqy8n2ZeyuYakwoxJCo2wcZjfTq1b7Pmy2lTiT8V6DEfOeFbWl9gh/X1?= =?iso-8859-1?Q?+WJup9+LzgTNQ4YKrd7Jlt8kpvcxsu5XvmWfbnH/vdZpGJxr/YfbFqwR+O?= =?iso-8859-1?Q?0iDDj+lXX5rEdpYYuTHn/6ZML6CWnCO2KUjy5xHiTVzVH4lcUfuPHoYXJJ?= =?iso-8859-1?Q?+d8ZVeTB+8F/1lRoVyYh/6YOjeLasIvYuxo9Bx8Nxs+fUgXcl9IHWtAerO?= =?iso-8859-1?Q?AeEnYkXZgKE3zE/nNe1pgJ+Xg98gSkClP5nq5cudNEJDSecwa+NVCmSmfU?= =?iso-8859-1?Q?gsYZFp6Xc4gzv5LDtkKyV7js6cIlvepVQPGA/LO5lBpP+/mvf0WFogiQoH?= =?iso-8859-1?Q?BTk+/5hN23DFXedcTgDHf49BTjYhGw6NmS0DOgq6eQyno0yrbIuS3Yu3EI?= =?iso-8859-1?Q?bc08ljofXKOy+S5gXlinkhq+TF5VRyd5f+W34izrmsLtlKHrccAHT22buE?= =?iso-8859-1?Q?AB7LIM415EWh5GqfFJlqzaTSUtlJgsmxNOhbf+o5CYXw8tc7zD3CXl1f9M?= =?iso-8859-1?Q?n7lVbT1FCjOMRmFB6Sd9t191re2ouFVybtgAcIGsrZxYnsQvFiYbx0tGBt?= =?iso-8859-1?Q?oK/5Z5kJ+pUNC7U+ESa4nTpyA0t6+Cnoz6X5w0yBmQBRwGIMsWGuFas7KV?= =?iso-8859-1?Q?8UAn87fNy8B/ArN+4+7P5KtwSFtTWbgVJji7JAJ1ZB0uIsRNYZUnywWr8d?= =?iso-8859-1?Q?az1Py3TF1f3Tt3M/O15d7rTR0WGsm0N4/4wD6lFA69nUyu0BchfSWjqty5?= =?iso-8859-1?Q?/kOnFKZBy7Q6g8APFlVXRwCwJ1tTNM8aEMF53/YCzsr8ee1Ubg04Q4YWam?= =?iso-8859-1?Q?Qkj4Ib69WFWnMnH0uNVCz1hzfctQer5zBNvzygiMzAN05QKCLh7yEjegzn?= =?iso-8859-1?Q?q19BLrvQz2eSgTGxf1FOHmHgk2hC268GjFBD3htVoffZlj6jAkL+tjbIOe?= =?iso-8859-1?Q?t9DiX5xqtxCUXeYLDaNm0HSRiYlcyyBkbZ1k9NYKkz9w1/r5kgcZYUi3Ie?= =?iso-8859-1?Q?kr1SMCRXAmxPCh0Ty0WMdbho9hMqHeKjtCdg8mAE5VIwbuKndkTiIOxmqr?= =?iso-8859-1?Q?yOgvEp17PP9x0qihm3hm42o1QxpufYHAMEEWdg5UrByCc/IkGq0cU/iRC/?= =?iso-8859-1?Q?VJXoySPg5nZgpTXmtqZpe4WS+HU9fO3XFyCqFHkM4R4oA40B33OPyp/+hl?= =?iso-8859-1?Q?fFkaAXEEFOuv+JltmcQQ5m6UzXrMDfVafor46V3q0TXeiglg80A93QAKXb?= =?iso-8859-1?Q?0aHLPTfv0pWh0d2rzlvengiuygt6TOrHYLONMcZTqfOnUQd1FjnRNZdQt8?= =?iso-8859-1?Q?Ubua3ynybSbuGhwpFICzNEcCqcLYM91?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0501MB1935;6:aVXS5gILHiFeGx1Mgpj5np1CtHUbnc130Mtx/X0BPwlXi7rZX1OI/TB8GPXzsOM4cH3sXasCk5wMdkt+ueay/1jB8i3SDL1GJ5itYrTItRCvD7NyrLxDC89n9MJ/mMtW7dGuleOYah5N4+sf991H86mXS+YoZ5jjBUiHSTj/YKdq2rEKQjYq3W4ExHhmAbGzQ74WCuPWBIky1/7c+GLV1I6nDAzHd8rBbU13o/SkafcXCNjoUunMmxnXdlKkzEKnr35Z2OP/s7PZlUmq+rZPGcbF10g4S1HR13s0bOFhqjyP4qV8d9o7RPP1Fu4umxityisEp81inYDVhc6ajFRFxuNSZ06dD+nhK+Jp6l3igKc=;5:tqmDVpWO8bDvQDK7g8YLHQ2JxW/8Mup1+T9mtSrajyL4oTX8aqAPhJsS7c/mMWI/3LEZJYLGWdJOXJc+uUwweKEHCFt8muQ2zw7Zs1diRdoxa+5kz21zmp5CdAPQzAwsDWpOnmFkEfQ3eNKAqNeCuA==;24:KDiiZMXOIXeRKQlb3+LY/TRxDzzMwAsVQKD2t7apn2NPERtaebXyq9HKICchLoJ+WeBamgo3wLhxJamDCpdTEtA9+vI5Ad44i9MtZyN7BfE=;7:ezmpas2SQq6XjXuMInp5/46tmShO9HI6t5S7XteV78g8wA/h2eUePHPvgLC/vkGPRcSvV746Ql1hbUqXLds9twiZwcfOGMFM6DM+9Pg/RZaTViz9Qy8Pmqz738TELvUOoXDqM7wTntP9v0IAc9Os7+ZKSDOGJ+pXFxBK02Xopziw8qZwxTSlaj8MV0HsyM3CgOXH2dhJpKym4p6ajhk442JGKfXt2OiyP4YIVeJmNWFw2nIQLVA0JGHI94UeCe7VK9iuod9QzTaFfh06MNNkyg== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2016 05:27:07.1534 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB1935 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --xgyAXRrhYN0wYx8y Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 22, 2016 at 11:23:59AM -0700, Joe Perches wrote: > The logging macros create a bit of duplicated code/text. >=20 > Use specialized functions to reduce the duplication. >=20 > (defconfig/x86-64) > $ size drivers/net/ethernet/mellanox/mlx5/core/built-in.o* > =A0=A0=A0text =A0=A0=A0data =A0=A0=A0=A0bss =A0=A0=A0=A0dec =A0=A0=A0=A0h= ex filename > =A0178634 =A0=A0=A02059 =A0=A0=A0=A0=A016 =A0180709 =A0=A02c1e5 drivers/n= et/ethernet/mellanox/mlx5/core/built-in.o.new > =A0188679 =A0=A0=A02059 =A0=A0=A0=A0=A016 =A0190754 =A0=A02e922 drivers/n= et/ethernet/mellanox/mlx5/core/built-in.o.old >=20 > The output changes now do not include line #, > but do include the function offset. >=20 > Signed-off-by: Joe Perches As far as I see all these functions are used in error paths, so no implication on performance is expected. And I'm fine with function offsets. Saeed, What do you think? Reviewed-by: Leon Romanovsky --xgyAXRrhYN0wYx8y Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXa3MlAAoJEORje4g2clincPIP/00hmu0VdtvzuFc/N8mYISVr LD2HYxKcqqa4Z1ARBrx/JS/37DFwIgKs1VIsQ58P8Ckb+oIwfSH/slLrXVdVtqDS mOR9WXTjHuwLKIlvaNp8+8LTA83pjKyQBSZoWzRUr600TK7OPV7TUkx5cMdjPc3r sksPSKIWYR30mIrEI5zfp35WaBucmaSZpb3EHJvuJwF3gFvE3Zm+gIlRHFEk+fv8 dxkNrNfBzOO6bkv8Os1j1tyMeGoLsmdFgrxMRUbu23YQwTTmkPj9EQVNu6ZrOVRs OHxChcql+nkleUh7X8WP/2hBXcy3PgTND5pHTUaBurJCymweAApoY0l0y6JoHJjL GKtiCvf0410UwE741+1x92XphJQAIJP7K+02amd+zO5u3JZW08x1go07GpKGIZh4 oOY51Aqy77Z8T7De+sMG0uKAaSYi+gX7Iz8yR0bhsmwZGTUS8ecHQW9u/OZyrhxm gPwLg/ZVCREbYs2Xkt6O5ymgoiV6NCw5jrD1LGGK3huDwwKcwqEkZmhSju6q+krL XHluelhO0TTtgVPYn58viKrRK4oy/K3gOijomEIYZmJHaElGrd9HWB+9d2WY69uE 0VLCW/porVyIVddyhm8RMCYVHELlCT6yLNrPgTr+INC7ULFixuLxoZKOXn+dIPWI LMCq3H5TWx25NleIHB1f =xIYj -----END PGP SIGNATURE----- --xgyAXRrhYN0wYx8y--