From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751272AbcFWF6L (ORCPT ); Thu, 23 Jun 2016 01:58:11 -0400 Received: from mail-bn1bon0076.outbound.protection.outlook.com ([157.56.111.76]:1281 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751023AbcFWF6J (ORCPT ); Thu, 23 Jun 2016 01:58:09 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yuri.Norov@caviumnetworks.com; Date: Thu, 23 Jun 2016 08:57:56 +0300 From: Yury Norov To: Joseph Myers CC: , , , , , , , , , , Yury Norov Subject: Re: [PATCH 21/27] [AARCH64] ILP32: introduce syscalls that pass off_t Message-ID: <20160623055756.GD13449@yury-N73SV> References: <1466485631-3532-1-git-send-email-ynorov@caviumnetworks.com> <1466485631-3532-23-git-send-email-ynorov@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [95.143.213.121] X-ClientProxiedBy: AM4PR0501CA0029.eurprd05.prod.outlook.com (10.167.83.167) To SN1PR07MB2256.namprd07.prod.outlook.com (10.164.47.150) X-MS-Office365-Filtering-Correlation-Id: aad5a9e4-d797-4a25-de71-08d39b2b58b5 X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2256;2:oFnId7hCAFVY2SATlKY7oAiZltfTftK1Y+ToXfySHHhdbRjlzf2gw2LvVwwm0TyAFKTlXigKOualALuGcQyoCvJQgphuFlBWyf69Y9fm5qYsfFzHrKiJ4i3CdPfzVCa/o6Sp8ZuSTwvj7Enl/UxkvuFkhe1qLZ5a6oLmpoQGevLWFnWk23ljePirRaZ/OKZ8;3:8972NjUx6Y08AXWf8TmZ0E5Q/LCOcnIKGUzBFbyxz4J+d+zvPsdS0Yjd0TYmoJlPpi1XGN24EN2DozCJ+/0y6oxv3woVUJKIWUPV8rWFHMm4NKl2hnWQfD1f9ouu26JY X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR07MB2256; X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2256;25:7LZ0ywe7EEuGvyCMVxGbN01Houvt2MYnIvAGswG6C9VXuaMUUNYVujWtWcRjN7TmDVxTt7da//796ob7SYSEg6oXgS7t3x83JatDvs5B3NAcTGU28nl9tsXLxph1wL51M8BT66U5c+Ml0NEozt+6sHIaw0J4pKaeofCXE8CgByzBH0j0bLeC3cO9Zt0/DCGHjEd+pJ7FqYUjH5O+Tx4TzNjdjoRbzI4aQykhbhosf4IxNNd94YIXq1dyrBqpQH1beeExhVIaYABIDBLtdlBzvxW7xlY2E4izMbsl07PIliJObnURpkHSs+/oKrtnPZGPKysqPxaCUYY7ExpmV+3l0OiirxNpOe5RhfinGLXjkFCTa6RUEF2J4kzJ+kO90Te6YsyZXchoUxb46jsbKUKWvBa9H7qnG+t0qrVr0UPpBKmc4MyA7D63SCQOHCohMLUapoJf8INJ1y77K6lNEeGXk76c+FDf9FyYKMG/ojmsu9a/F37KKAbvmpXNWUtYg4JgMHMyWB3J/vCKjK5dQ7OzLJ3c7VRvoScTiAKpffUgqcjVvdaAAJuNEniTkShxXj4ezOLT4cpJu031u9VfkbgMqw2JbiAifU5Rbq5wQWhg4oVW0KsKGRis+3UNYz7KHTpDesnNuZbE7DREO8KCpLNsrAT7Uru71qIAsXi4jR5pMIH9YsRVcIOcb+6mBvhNkbtGmHSsbkGhBewOspmKhpZo8mXUGJy86h+UrAgBhqqArvoAfQvElVytk73zV7qXpfRiPJfbknpVKCOmAhIIaIfgDt5thDruu/GzLmKwQITgxzGOqrUgbpXve9TH28JwO2F6lP0jYA0SzobgQdEU/cut+2alXnlKdGWsP55ZPIKlyb2GJbPIwaP1h3rRMfWbFo53 X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2256;20:AgyN46HdF16J94wO1019CQCJ8FCtUxSb4Yrl6PeUDbeWZY48bixaWUMA1wr8WHWG4cxLwi2M0UuC1SG40vZwZiXzGMrYflGGViybIhQGJ2KtAWepv9Q8CO5mCgKKJSt8KDpegxqzWMutw4HAKlzyC5BDuuL4KANFA8E4hxx+g+sm/WYlMyfXi0tz4NreB0CfyQSJLR4Gp4hcB3Kz8Qz84hOxBpV/c9ir1lgHxucL9jsQlCMMUOanSL3KopzumZ0LDs5QibGbO7+/fiu2jQduQBM51SMOXREqJSCziOkLVGZfQuRE741wFdgIUioI5UUIvadOob/TMfCHF46q4FP4JDbGDYJEY6GQ00zTU7/mF2m0OXJTeQsPMS01rKr1vEfsRkbuGUVw0F8RIzi7tZGiTKPRXzVzx+KuR7ZlD4BLCaqFllJJtJ3KQZh/5z5NY3ElkRMmjH3WG85aLDMETTXAP/l1MJNBCm5TJ+ICDqcqsdMbVBhrE9jA6Z+HdFcTMAu7AWp2WQLUWWKQt4re3QqHUL5cQii9MPBK0OF+LCyLQQR1d9oTDMLV9Fk6B8C1nEthjlq85fOqWqGExm+Fg6+Djnn1jMEI6UgkW7TGvEFw6Zs= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(166708455590820); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:SN1PR07MB2256;BCL:0;PCL:0;RULEID:;SRVR:SN1PR07MB2256; X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2256;4:ZOn2AEhjJsBBdifu/YorxPf/xwQgyePh1dlXt8v5fB4FkNoMXE/sU7t4+PC3qKY2PAFF+cNzXO7BO9G1aAhWrtilNIZxdvFKVDReccb+wz1MQ9plSDFvAssi8wT1TOaJquHXk5enUEi9TIdxHx+ahDZBOVqSj7qCI+pu5N5V15Ne5X/rF+50/jDtmNgPw3atIpbsJzduxv+pmlQ2UyCrDuwXJ8Ao93TsPuNBWGpR1Mbh8DG4XRtdKTUoG3PyPFrBo9qGXid5Y3Q3alWNRzaOEBxGKQRrx90hZy15dLGu7SqbL0zAS0U0fL0Dt1hD+zdLdWtsS+rX6rSz+DISa4WJLS2iMFPH0QlM5MM5qmivFZIHRmFNQxeURw9a0seetm6mts+0tHeiWeO0RLIOvH41JX99320b+s0ByepcHeKDcSI= X-Forefront-PRVS: 098291215C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6069001)(6009001)(7916002)(189002)(199003)(24454002)(9686002)(50466002)(42186005)(68736007)(76506005)(33716001)(105586002)(92566002)(46406003)(106356001)(7736002)(305945005)(101416001)(3846002)(15975445007)(6116002)(54356999)(76176999)(66066001)(110136002)(47776003)(586003)(19580395003)(83506001)(4326007)(19580405001)(8676002)(81166006)(81156014)(2906002)(50986999)(97736004)(2950100001)(4001350100001)(97756001)(1076002)(189998001)(33656002)(77096005)(7846002)(23726003);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR07MB2256;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN1PR07MB2256;23:8GasyAN98yJWT8e1IdmMUdyvlLgFcNeQNN8nYZJhM?= =?us-ascii?Q?44g21ngYaIpERNg9odJkzWG92qNUeBnypSSwNPkR1ABAnmUHnGUX9F7B3ZkX?= =?us-ascii?Q?9FNWut89nE1/L47U4GIZJz2vxgeJ4o3WAV4uooKXD1Hl4JMo2KtjDtFEeBKR?= =?us-ascii?Q?xjOy0xZDsjgNWPJLnS5YRn4QU95geXYqVpSIalnie/whX3G+uBGJcf11RtEh?= =?us-ascii?Q?FvMXOdQF2pbPdfu+/OvcFbaclyQ1D0f5co4c7b1s64myczTlRWvLSsBW06gD?= =?us-ascii?Q?dxyuNgGJnhNr2S71km8huhzPc+1dSkj8Vc6Vj0hov7A1LR+3PPVNwA0LL7yN?= =?us-ascii?Q?szow21kFZNH2P+kQbUghdX8FqUrN5udofwRG6uiq39RmggIMPxSb9vlnWCDp?= =?us-ascii?Q?1Zg6O1vdyZg6K4DQn+9Lg1tP/YZJoRyi+jYhSVp6FeWTSCsddOLGZgDA9KIy?= =?us-ascii?Q?x+CaddkttlhCDrNrXuaLVDLjCL9CwVwrnl4KN2EIqQ5zJ9r9Lor9vEJmpdcD?= =?us-ascii?Q?T6YmgxdmbofUm9faz3mJLg7uIO3KrFnk1yB1wRy0vxMl13IUgfYb5f5vkTHE?= =?us-ascii?Q?jgbw++cE0Fw+cXftZD0aa0kug7WzzG/XIZUkphxB+JhjDD6dOAJih5N8pNqU?= =?us-ascii?Q?QUwdksU/tTE4zSr/U97uy4XA8iyct8omY2TDSANkgy7nc4MBWeX3r2+m/j+H?= =?us-ascii?Q?tetp/m4n1gooFPbgKtiWKTy6uGVBKO+FUSAD1Ou7nW7860pdkUsN3Gf2mLMf?= =?us-ascii?Q?CGnJo9UbCS5Ex8bOXOi9yunv1u+9SKJwS4+jH2qoGE12dTiX9qocoEtTVJvs?= =?us-ascii?Q?h3Zo3ahSOF7UefdozOxf7u40asaK1tA2HvLN4vqcaZjfg5xJr4CHFE2ZbyPo?= =?us-ascii?Q?97VrZlrllYza59Z9tzQYb2/qYEvvYqFLHMwAq2HhR2+rPnW1iOSneN+UBNQl?= =?us-ascii?Q?CtDDbC1AQRxUQE3j0eDx9BeV96Vd8PCAHZXkBWqAi3gbVA1JUAr0+2iudHqB?= =?us-ascii?Q?2ORgkwmsW4cxVCOD/wQkoBT8M3gWriyXwpJxj7Yyd35rjCY5Ed/E3va32aBJ?= =?us-ascii?Q?ZPaS0DooPgwdsgVwMMCAvUPrSLLnrweqBPfLiYurYBM7yTJrHw6CuHeIH7t3?= =?us-ascii?Q?ldjQWK6s8biHpUiXT0YP41gPttJu0MkLjcS3w/+5FzFbmlc28/m1zeWAEsX7?= =?us-ascii?Q?RbX9plAVHJjENF7vZth29bzs6o+BYJ63caa?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2256;6:d8jU2OXg5FIJI5VFc5oHg1uO86fDsRcOlb9P2EajsEhZH4SEThRcRx4CY7JsLi5PSLQIMMkv4DEQkSxXQhiYpuFlFQ8LqM6bg0vZcnoFiivW1NPKzz6EUP4fAEr5EU5VOGVTg3wLKS4/YgIW5iNydFnBTQRjSpC9lluON5V0/PVaCkXXnvb/mvI3zDRpw/8FKFjG0XzwmYNVYpGVPwWtg3ZNyLaBomEnksqYNuufxgP2DavXSv/EZtrgObZEbVbu989weP5NumGXdXGeyHcOAAL41JyxZ6sUi2ApIQbY6Wxfs9B4gv/btS2Votod0fR5;5:3JO4yQi0gS5OGdBB2r5Csi599bGSH5F19tw0bGPRLQAUzPR9Mtp5rxzGt2Pt5jnxY3o1MF7T9CCsJ/VFurbaCkXtH2FoYKecVmUS5i9VEZIH1dcyGds29WKZCu1FthHV2tW+9DFOp5uQt1jjvU78+g==;24:qH/PJvAwn//a5UBDSP0gJGW0TICTMdw3N4G32ZugYF91ixw5oMXFswYsVyaDLODd6HEglnuga64h6PiIMOgyIIIKVkpJAjckeCxag15gnyo=;7:Q2vsCNl3+SFs3xiO7f/BSKQ7vwwT3A8/qDBAOxagiKonur4GZTdoA80SGfYyhvGth5uhuLTxrkjsFQciZGmQQcvrs3zTc1NIKFpIM4QauX+WThRXPFri/HLhd37Eh8P5oVfqNsoQBaYHmuoQFHmqL/XcVqJpTANSGDbtbfnhbHe5wzf9olSDPAWZUeoVgt7GBxaF3HDmvmm/lxHwNZ24ey7zRTb/mVFrlhqDhVOXLw3Qi4HWGyRojkPl23bVwT13hI7tIwgb4uzcBOjJp3MR3Q== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2016 05:58:05.9951 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR07MB2256 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 21, 2016 at 10:35:27AM +0000, Joseph Myers wrote: > On Tue, 21 Jun 2016, Yury Norov wrote: > > > create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/fallocate.c > > create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/fallocate64.c > > create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/ftruncate.c > > create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/ftruncate64.c > > create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/llseek.c > > create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/lseek.c > > create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/mmap.c > > create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/posix_fadvise.c > > create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/posix_fadvise64.c > > create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/pread.c > > create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/pread64.c > > create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/pwrite.c > > create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/pwrite64.c > > create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/readahead.c > > create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/truncate.c > > create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/truncate64.c > > I don't like how you need so many ilp32 files. > > Presumably this is a new convention to be followed for all future ilp32 > ABIs on 64-bit architectures. Meaning that you should have some sysdeps > macros to say whether this convention is in use and then make either the > sysdeps/unix/sysv/linux files, or the .../generic files, or a new > architecture-independent sysdeps directory, implement that convention. > > Note also how Adhemerval recently unified pread / pwrite implementations. > Adding new files for those functions goes against that unification. > > -- > Joseph S. Myers > joseph@codesourcery.com Hi Joseph, There's RISC-V convention that implements very similar approach to aarch64/ilp32. https://github.com/manuelafm/riscv-gnu-toolchain/commits/master But as I understand, there is much work there to be done before upstreaming. So for now I think it's simpler to have this ABI in sysdeps, and be in touch with RISC-V team to have aarch64/ilp32 compatible to RISC-V. After RISC-V merge, we can switch aarch64/ilp32 to it and drop unneeded sysdeps. If you mean something different, could you explain it in details, or suggest an action plan for such rework. Yury.