From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751821AbcFWIZz (ORCPT <rfc822;w@1wt.eu>);
	Thu, 23 Jun 2016 04:25:55 -0400
Received: from mga01.intel.com ([192.55.52.88]:28729 "EHLO mga01.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751063AbcFWIZx (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 23 Jun 2016 04:25:53 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,515,1459839600"; 
   d="scan'208";a="723821733"
Date: Thu, 23 Jun 2016 11:25:49 +0300
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Greg KH <gregkh@linuxfoundation.org>, Oliver Neukum <oneukum@suse.com>,
        Felipe Balbi <felipe.balbi@linux.intel.com>,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCHv3 1/2] usb: USB Type-C connector class
Message-ID: <20160623082549.GB27263@kuha.fi.intel.com>
References: <1466520711-125758-1-git-send-email-heikki.krogerus@linux.intel.com>
 <1466520711-125758-2-git-send-email-heikki.krogerus@linux.intel.com>
 <20160622215428.GA15297@roeck-us.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160622215428.GA15297@roeck-us.net>
User-Agent: Mutt/1.6.1 (2016-04-27)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On Wed, Jun 22, 2016 at 02:54:28PM -0700, Guenter Roeck wrote:
> Hi,
> 
> > +
> > +static void typec_remove_partner(struct typec_port *port)
> > +{
> > +	WARN_ON(port->partner->alt_modes);
> 
> You are setting partner->alt_modes in typec_register_altmodes(),
> but you don't clear it in typec_unregister_altmodes().
> 
> Does this work for you ? I always get the warning when I remove a cable.

Damn it.. I have managed to just ignore the warning.

Yeah, this has to be fixed. Sorry about that.


Thanks,

-- 
heikki