From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751695AbcFWJ75 (ORCPT ); Thu, 23 Jun 2016 05:59:57 -0400 Received: from foss.arm.com ([217.140.101.70]:52696 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751347AbcFWJ74 (ORCPT ); Thu, 23 Jun 2016 05:59:56 -0400 Date: Thu, 23 Jun 2016 10:59:51 +0100 From: Catalin Marinas To: Dmitry Vyukov Cc: linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, ryabinin.a.a@gmail.com, kasan-dev@googlegroups.com, glider@google.com Subject: Re: [PATCH] mm: prevent KASAN false positives in kmemleak Message-ID: <20160623095951.GH6521@e104818-lin.cambridge.arm.com> References: <1466617631-68387-1-git-send-email-dvyukov@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466617631-68387-1-git-send-email-dvyukov@google.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 22, 2016 at 07:47:11PM +0200, Dmitry Vyukov wrote: > When kmemleak dumps contents of leaked objects it reads whole > objects regardless of user-requested size. This upsets KASAN. > Disable KASAN checks around object dump. > > Signed-off-by: Dmitry Vyukov > --- > mm/kmemleak.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/kmemleak.c b/mm/kmemleak.c > index e642992..04320d3 100644 > --- a/mm/kmemleak.c > +++ b/mm/kmemleak.c > @@ -307,8 +307,10 @@ static void hex_dump_object(struct seq_file *seq, > len = min_t(size_t, object->size, HEX_MAX_LINES * HEX_ROW_SIZE); > > seq_printf(seq, " hex dump (first %zu bytes):\n", len); > + kasan_disable_current(); > seq_hex_dump(seq, " ", DUMP_PREFIX_NONE, HEX_ROW_SIZE, > HEX_GROUP_SIZE, ptr, len, HEX_ASCII); > + kasan_enable_current(); > } Acked-by: Catalin Marinas