From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751713AbcFWK0q (ORCPT ); Thu, 23 Jun 2016 06:26:46 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:33858 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751265AbcFWK0p (ORCPT ); Thu, 23 Jun 2016 06:26:45 -0400 Date: Thu, 23 Jun 2016 11:26:34 +0100 From: Mark Brown To: Keerthy Cc: Keerthy , tony@atomide.com, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, t-kristo@ti.com, russ.dill@ti.com, robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk Message-ID: <20160623102634.GX28202@sirena.org.uk> References: <1466412218-5906-1-git-send-email-j-keerthy@ti.com> <1466412218-5906-2-git-send-email-j-keerthy@ti.com> <20160621190848.GF28202@sirena.org.uk> <576A64EA.4000607@ti.com> <20160622101611.GI28202@sirena.org.uk> <576A67D9.6080707@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="p11K2BJEgMZL61bg" Content-Disposition: inline In-Reply-To: <576A67D9.6080707@ti.com> X-Cookie: Beware of Bigfoot! User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/9] regulator: tps65217: Enable suspend configuration X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --p11K2BJEgMZL61bg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 22, 2016 at 03:56:33PM +0530, Keerthy wrote: > I will allocate memory for TPS65217_NUM_REGULATOR strobes during regulator > probe. Is this approach okay? It should be I think. Some more comments or changelog explaining what's going on with the sequencing would also help. --p11K2BJEgMZL61bg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXa7lZAAoJECTWi3JdVIfQJG8H/i2uB7kAGeoUpdxJ2yswedLK sd5zeUAUm7Vd2HMtB3CQmZ+47t9DaO3WkulOgxAdvg+MXVBCfMqgCm8FPD0PKV2v +Yt7F98irFgHyQQqwncJSDCbpdcUFeTcjTOnpqAJHWbnjytSgNsq1ZXHOLyBNqhR pogKDZj3elndh3CJJlZF2ALUryPc9BZwFx7tIVBVtt8tsndWzatqKv0L9cETJNcf GAIqNOYyMswrfjhucFfCW8YqBFHf3JLTaLvoyuPmX2xpwjJQP1mmp26l8PTiP6aa yNvnTseBIhJ2iWNPY84e97AksdGA76Fp8bMJRd+/IIcZDtRfoQW1ox8leL25Fv0= =XVXs -----END PGP SIGNATURE----- --p11K2BJEgMZL61bg--