From: Arnd Bergmann <arnd@arndb.de>
To: Jens Axboe <axboe@fb.com>
Cc: "Nicholas A . Bellinger" <nab@linux-iscsi.org>,
Mike Christie <mchristi@redhat.com>,
Andy Grover <agrover@redhat.com>, Hannes Reinecke <hare@suse.com>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Davidlohr Bueso <dave@stgolabs.net>,
linux-efi@vger.kernel.org, linux-block@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH v2 2/3] partition/efi: use bdev_logical_block_count()
Date: Thu, 23 Jun 2016 15:30:15 +0200 [thread overview]
Message-ID: <20160623133016.3781907-2-arnd@arndb.de> (raw)
In-Reply-To: <20160623133016.3781907-1-arnd@arndb.de>
Enabling CONFIG_UBSAN_SANITIZE_ALL on ARM caused a link error:
last_lba.part.0':
:(.text+0xc3440): undefined reference to `____ilog2_NaN'
:(.text+0xc3538): undefined reference to `__aeabi_uldivmod'
:(.text+0xc38e8): undefined reference to `__aeabi_uldivmod'
This is caused by gcc not behaving in the expected ways with __builtin_constant_p(),
but it also points to somewhat inefficient code based on a 64-bit
division.
I have introduced a better bdev_logical_block_count() now, so we
can use that here.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
block/partitions/efi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/partitions/efi.c b/block/partitions/efi.c
index bcd86e5cd546..7b1a62073d34 100644
--- a/block/partitions/efi.c
+++ b/block/partitions/efi.c
@@ -149,8 +149,8 @@ static u64 last_lba(struct block_device *bdev)
{
if (!bdev || !bdev->bd_inode)
return 0;
- return div_u64(bdev->bd_inode->i_size,
- bdev_logical_block_size(bdev)) - 1ULL;
+
+ return bdev_logical_block_count(bdev) - 1;
}
static inline int pmbr_part_valid(gpt_mbr_record *part)
--
2.9.0
next prev parent reply other threads:[~2016-06-23 13:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 13:30 [PATCH v2 1/3] block: provide helpers for reading block count Arnd Bergmann
2016-06-23 13:30 ` Arnd Bergmann [this message]
2016-06-23 13:30 ` [PATCH v2 3/3] target/iblock: use bdev_logical_block_count() Arnd Bergmann
2016-06-23 14:22 ` [PATCH v2 1/3] block: provide helpers for reading block count Christoph Hellwig
2016-06-23 15:52 ` Sagi Grimberg
2016-06-27 16:30 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160623133016.3781907-2-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=agrover@redhat.com \
--cc=axboe@fb.com \
--cc=dave@stgolabs.net \
--cc=hare@suse.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mchristi@redhat.com \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome