From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751357AbcFWNyk (ORCPT ); Thu, 23 Jun 2016 09:54:40 -0400 Received: from merlin.infradead.org ([205.233.59.134]:49053 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750863AbcFWNyj (ORCPT ); Thu, 23 Jun 2016 09:54:39 -0400 Date: Thu, 23 Jun 2016 15:54:29 +0200 From: Peter Zijlstra To: Matt Fleming Cc: Yuyang Du , mingo@kernel.org, linux-kernel@vger.kernel.org, umgwanakikbuti@gmail.com, bsegall@google.com, pjt@google.com, morten.rasmussen@arm.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com Subject: Re: [RFC PATCH 08/11] sched: Remove SD_WAKE_AFFINE flag and replace it with SD_BALANCE_WAKE Message-ID: <20160623135429.GK30154@twins.programming.kicks-ass.net> References: <1466041775-4528-1-git-send-email-yuyang.du@intel.com> <1466041775-4528-9-git-send-email-yuyang.du@intel.com> <20160623130433.GF8415@codeblueprint.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160623130433.GF8415@codeblueprint.co.uk> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 23, 2016 at 02:04:33PM +0100, Matt Fleming wrote: > On Thu, 16 Jun, at 09:49:32AM, Yuyang Du wrote: > > --- a/include/linux/sched.h > > +++ b/include/linux/sched.h > > @@ -1014,7 +1014,6 @@ extern void wake_up_q(struct wake_q_head *head); > > #define SD_BALANCE_EXEC 0x0004 /* Balance on exec */ > > #define SD_BALANCE_FORK 0x0008 /* Balance on fork, clone */ > > #define SD_BALANCE_WAKE 0x0010 /* Balance on wakeup */ > > -#define SD_WAKE_AFFINE 0x0020 /* Wake task to waking CPU */ > > #define SD_SHARE_CPUCAPACITY 0x0080 /* Domain members share cpu power */ > > #define SD_SHARE_POWERDOMAIN 0x0100 /* Domain members share power domain */ > > #define SD_SHARE_PKG_RESOURCES 0x0200 /* Domain members share cpu pkg resources */ > > I'm curious - doesn't this break userspace ABI? These flags are > exported via procfs, so I would have assumed removing or changing the > value of any of these constants would be forbidden. Generally I ignore this little issue. Also, I suppose we should move that whole sched_domain cruft into /debug/sched/ or so.