From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751443AbcFWOAi (ORCPT ); Thu, 23 Jun 2016 10:00:38 -0400 Received: from mail.skyhub.de ([78.46.96.112]:34530 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751189AbcFWOAh (ORCPT ); Thu, 23 Jun 2016 10:00:37 -0400 Date: Thu, 23 Jun 2016 16:00:28 +0200 From: Borislav Petkov To: Matt Fleming Cc: Ard Biesheuvel , Dave Young , linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org Subject: Re: [PATCH 02/11] x86/efi: Consolidate region mapping logic Message-ID: <20160623140028.GD20951@nazgul.tnic> References: <1466681690-5850-1-git-send-email-matt@codeblueprint.co.uk> <1466681690-5850-3-git-send-email-matt@codeblueprint.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1466681690-5850-3-git-send-email-matt@codeblueprint.co.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 23, 2016 at 12:34:41PM +0100, Matt Fleming wrote: > EFI regions are currently mapped in two separate places. The bulk of > the work is done in efi_map_regions() but when CONFIG_EFI_MIXED is > enabled the additional regions that are required when operating in > mixed mode are mapping in efi_setup_page_tables(). > > Pull everything into efi_map_regions() and refactor the test for > which regions should be mapped into a should_map_region() function. > Generously sprinkle comments to clarify the different cases. > > Cc: Ard Biesheuvel > Cc: Borislav Petkov > Signed-off-by: Matt Fleming > --- > arch/x86/platform/efi/efi.c | 50 ++++++++++++++++++++++++++++++++++++------ > arch/x86/platform/efi/efi_64.c | 20 ----------------- > 2 files changed, 43 insertions(+), 27 deletions(-) Looks good. Acked-by: Borislav Petkov -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --