From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751424AbcFWOMX (ORCPT ); Thu, 23 Jun 2016 10:12:23 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:53388 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751084AbcFWOMU (ORCPT ); Thu, 23 Jun 2016 10:12:20 -0400 From: Arnd Bergmann To: "David S. Miller" Cc: Arnd Bergmann , Vivien Didelot , Andrew Lunn , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] dsa: mv88e6xxx: hide unused functions Date: Thu, 23 Jun 2016 16:13:22 +0200 Message-Id: <20160623141409.356324-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:gKRrOSonHGk175wMDy46mo0NtBLrGZf01DFnIebMlIaJiu5tufM KLieaNJBYSIvuAKoc/d4DZ+ScFMZAFaQ01+pgJh7x9hqfseYwtpBt8mXkShx7Z5O2fz5Ewx Zn+Y/QUMORCHi0lbref75LsZug567GcvmYsQJ14l3HP+Dsw9Ya9ktU5CjF3CjzO+fR5gKMs Dw/WaqTmzB8kd0HfInsDQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:V+Cgeunekrg=:tEN6Uy7nWRJ1JR4oj+4mtp fy9I8mkiIRLA0/H/cstJZhw9R3IT6bTTzI2/WUCUJwU/9ePiC6Kp9mybYSKme6iW0c170rceD tKZspISO+Lc92Q4INJ73wHXUWOpGBKYwzlXIAjYIBiTS+18uFzShzaX/JAOchb77RNBwN1JrR KCtfBlDfmeRMs6Czv7P3Wm5Ueq9pPZoa+Uxc4CccqEY0YnnL+M/71s8DTWp+2+pP1cOPXtcd8 MGIcKTE/3Ysc/2RtyF5+MKaDDf9ASmaKfvAdFmPRnaG/B+JfJ9PX8WzQE8WGcMAWvK2x8ODGl 46QQQxcB53CftWhDlHmkF+Cq6yEWlFXL8u9NV3DKK0Z+r9tPGWRavCbf705YRZ7Wh8rwX+8AG dvGgOwtXk1GVmnqBFRQ13R+xxW2m6/JUBhHAdQA+k27O+L/LP1ZY/Bb1Kj2JdFEAZr/JwUe+O I6S1SsKtmR9gHa9lrue+HNgEi6HY+9HUajlXz3NGp/Y1a31S2tX7YL+RaA9CUhNScNW8pC6EH gYugz0rjd26tLLI0FfP975gUHw30ZVP1+Aaz4CBEYqIphOli5Ks23UeVwn7NvnqsBYGAQm7zJ A4qOQLTpkgS+bkF3S+mspU7UNcS/811O7YqCxJkhmeIRzfipd3QO3ezijvCkonDvGF3xKOpyP KI0M2y6I4xpfXyhpi/f0ZOcAHB61QeY3BJFXPbs3Iu3y5YMXplq4+9bbbEOkyTitH5Wk= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When CONFIG_NET_DSA_HWMON is disabled, we get warnings about two unused functions whose only callers are all inside of an #ifdef: drivers/net/dsa/mv88e6xxx.c:3257:12: 'mv88e6xxx_mdio_page_write' defined but not used [-Werror=unused-function] drivers/net/dsa/mv88e6xxx.c:3244:12: 'mv88e6xxx_mdio_page_read' defined but not used [-Werror=unused-function] This adds another ifdef around the function definitions. The warnings appeared after the functions were marked 'static', but the problem was already there before that. Signed-off-by: Arnd Bergmann Fixes: 57d3231057e9 ("net: dsa: mv88e6xxx: fix style issues") --- drivers/net/dsa/mv88e6xxx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c index 9b116d8d4e23..2a95f2d6cf09 100644 --- a/drivers/net/dsa/mv88e6xxx.c +++ b/drivers/net/dsa/mv88e6xxx.c @@ -3241,6 +3241,7 @@ unlock: return err; } +#ifdef CONFIG_NET_DSA_HWMON static int mv88e6xxx_mdio_page_read(struct dsa_switch *ds, int port, int page, int reg) { @@ -3266,6 +3267,7 @@ static int mv88e6xxx_mdio_page_write(struct dsa_switch *ds, int port, int page, return ret; } +#endif static int mv88e6xxx_port_to_mdio_addr(struct mv88e6xxx_priv_state *ps, int port) -- 2.9.0