From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752046AbcFWQSQ (ORCPT ); Thu, 23 Jun 2016 12:18:16 -0400 Received: from mga04.intel.com ([192.55.52.120]:11369 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751048AbcFWQSN (ORCPT ); Thu, 23 Jun 2016 12:18:13 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,517,1459839600"; d="scan'208";a="981972695" Date: Thu, 23 Jun 2016 09:18:04 -0700 From: Andi Kleen To: Adrian Hunter Cc: Arnaldo Carvalho de Melo , Jiri Olsa , linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 0/3] perf script: Add callindent option Message-ID: <20160623161804.GF25121@tassilo.jf.intel.com> References: <1466689258-28493-1-git-send-email-adrian.hunter@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466689258-28493-1-git-send-email-adrian.hunter@intel.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 23, 2016 at 04:40:55PM +0300, Adrian Hunter wrote: > Hi > > Andi Kleen sent a couple of patches to add a callindent option to > perf script. Andi was agreeable to this alternative implementation. > > While there are some differences in the resulting output, the main > difference is: > > 1. Tell the decoder to feed branches to the thread stack, which has the > advantage that it happens before branch filtering and so can be used > with different itrace options (e.g. it still works when only showing > calls, even though the thread stack needs to see calls and returns). Also > it does not conflict with using the thread stack to get callchains. Looks all good to me. Acked-by: Andi Kleen Thanks, -Andi