From: Steven Rostedt <rostedt@goodmis.org>
To: John Kacur <jkacur@redhat.com>
Cc: rt-users <linux-rt-users@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Clark Williams <williams@redhat.com>
Subject: Re: [PATCH 3/3] rt-tests: Add cyclicdeadline and deadline_test to the Make system
Date: Thu, 23 Jun 2016 17:47:46 -0400 [thread overview]
Message-ID: <20160623174746.36d3657d@gandalf.local.home> (raw)
In-Reply-To: <1466683911-10994-4-git-send-email-jkacur@redhat.com>
On Thu, 23 Jun 2016 14:11:51 +0200
John Kacur <jkacur@redhat.com> wrote:
> index 9c50456f7419..f530488545e0 100644
> --- a/src/sched_deadline/cyclicdeadline.c
> +++ b/src/sched_deadline/cyclicdeadline.c
> @@ -1,4 +1,6 @@
> +#ifndef _GNU_SOURCE
> #define _GNU_SOURCE
> +#endif
> #include <pthread.h>
> #include <stdarg.h>
> #include <stdlib.h>
> diff --git a/src/sched_deadline/deadline_test.c b/src/sched_deadline/deadline_test.c
> index 8a813c494520..2794730febc4 100644
> --- a/src/sched_deadline/deadline_test.c
> +++ b/src/sched_deadline/deadline_test.c
> @@ -29,7 +29,9 @@
> * Look for "simple_test"
> *
> */
> +#ifndef _GNU_SOURCE
> #define _GNU_SOURCE
> +#endif
I'd say nuke these if they are already defined via the Makefile or
something. I can move the define to the Makefile in my github too.
-- Steve
> #include <pthread.h>
> #include <stdarg.h>
> #include <stdlib.h>
next prev parent reply other threads:[~2016-06-23 21:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 12:11 [PATCH 0/3] rt-tests: sched_deadline tests John Kacur
2016-06-23 12:11 ` [PATCH 1/3] rt-tests: Makefile, change version to 1.1 John Kacur
2016-06-23 12:11 ` [PATCH 2/3] rt-tests: Add cyclicdeadline and deadline_test John Kacur
2016-06-23 12:11 ` [PATCH 3/3] rt-tests: Add cyclicdeadline and deadline_test to the Make system John Kacur
2016-06-23 21:47 ` Steven Rostedt [this message]
2016-06-24 11:40 ` John Kacur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160623174746.36d3657d@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®