mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephan Linz <linz@li-pro.net>
To: linux-leds@vger.kernel.org, linux-ide@vger.kernel.org
Cc: "Stephan Linz" <linz@li-pro.net>,
	"Joseph Jezak" <josejx@gentoo.org>,
	"Jörg Sommer" <joerg@alea.gnuu.de>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Jacek Anaszewski" <j.anaszewski@samsung.com>,
	"Richard Purdie" <rpurdie@rpsys.net>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Jonathan Corbet" <corbet@lwn.net>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org
Subject: [PATCH v5] leds: documentation: 'ide-disk' to 'disk-activity'
Date: Thu, 23 Jun 2016 21:38:46 +0200	[thread overview]
Message-ID: <20160623193857.14538-1-linz@li-pro.net> (raw)
In-Reply-To: <576B8467.3060407@samsung.com>

Cc: Joseph Jezak <josejx@gentoo.org>
Cc: Jörg Sommer <joerg@alea.gnuu.de>
Cc: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Stephan Linz <linz@li-pro.net>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
---
Changes in v5:
  - Keep documentation for the old 'ide-disk' device tree
    binding, but mark as deprecated and refer to the new
    trigger 'disk-activity'.

Changes in v4:
  - Keep the 'ide-disk' trigger and add a second one
    for 'disk-activity'.

Changes in v3:
  - Port to kernel 4.x
  - Split into platform independent and dependent parts.

v2: https://patchwork.ozlabs.org/patch/117485/
v1: http://dev.gentoo.org/~josejx/ata.patch
---
 Documentation/devicetree/bindings/leds/common.txt    | 5 ++++-
 Documentation/devicetree/bindings/leds/leds-gpio.txt | 4 ++--
 Documentation/laptops/asus-laptop.txt                | 2 +-
 Documentation/leds/leds-class.txt                    | 2 +-
 4 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt
index af10678..1c32e31 100644
--- a/Documentation/devicetree/bindings/leds/common.txt
+++ b/Documentation/devicetree/bindings/leds/common.txt
@@ -25,8 +25,11 @@ Optional properties for child nodes:
 		   system
      "default-on" - LED will turn on (but for leds-gpio see "default-state"
 		    property in Documentation/devicetree/bindings/gpio/led.txt)
+     "disk-activity" - LED indicates disk activity, the old name "ide-disk" is
+                       still valid for backward compatibility
      "heartbeat" - LED "double" flashes at a load average based rate
-     "ide-disk" - LED indicates disk activity
+     "ide-disk" - LED indicates IDE disk activity (deprecated), do not use for
+                  new implementation, use the new "disk-activity" name instead
      "timer" - LED flashes at a fixed, configurable rate
 
 - led-max-microamp : Maximum LED supply current in microamperes. This property
diff --git a/Documentation/devicetree/bindings/leds/leds-gpio.txt b/Documentation/devicetree/bindings/leds/leds-gpio.txt
index cbbeb18..5b1b43a 100644
--- a/Documentation/devicetree/bindings/leds/leds-gpio.txt
+++ b/Documentation/devicetree/bindings/leds/leds-gpio.txt
@@ -33,9 +33,9 @@ Examples:
 leds {
 	compatible = "gpio-leds";
 	hdd {
-		label = "IDE Activity";
+		label = "Disk Activity";
 		gpios = <&mcu_pio 0 GPIO_ACTIVE_LOW>;
-		linux,default-trigger = "ide-disk";
+		linux,default-trigger = "disk-activity";
 	};
 
 	fault {
diff --git a/Documentation/laptops/asus-laptop.txt b/Documentation/laptops/asus-laptop.txt
index 79a1bc6..5f28587 100644
--- a/Documentation/laptops/asus-laptop.txt
+++ b/Documentation/laptops/asus-laptop.txt
@@ -72,7 +72,7 @@ LEDs
     echo 1 >  /sys/class/leds/asus::mail/brightness
   will switch the mail LED on.
   You can also know if they are on/off by reading their content and use
-  kernel triggers like ide-disk or heartbeat.
+  kernel triggers like disk-activity or heartbeat.
 
 Backlight
 ---------
diff --git a/Documentation/leds/leds-class.txt b/Documentation/leds/leds-class.txt
index 44f5e6b..f1f7ec9 100644
--- a/Documentation/leds/leds-class.txt
+++ b/Documentation/leds/leds-class.txt
@@ -11,7 +11,7 @@ brightness support so will just be turned on for non-zero brightness settings.
 The class also introduces the optional concept of an LED trigger. A trigger
 is a kernel based source of led events. Triggers can either be simple or
 complex. A simple trigger isn't configurable and is designed to slot into
-existing subsystems with minimal additional code. Examples are the ide-disk,
+existing subsystems with minimal additional code. Examples are the disk-activity,
 nand-disk and sharpsl-charge triggers. With led triggers disabled, the code
 optimises away.
 
-- 
2.9.0

  reply	other threads:[~2016-06-23 19:39 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-08 22:29 [PATCH v3 1/7] leds: convert IDE trigger to common disk trigger Stephan Linz
2016-06-08 22:29 ` [PATCH v3 2/7] leds: documentation: 'ide-disk' to 'disk-activity' Stephan Linz
2016-06-21 15:05   ` Mark Rutland
2016-06-22  7:55     ` Jacek Anaszewski
2016-06-22 10:16       ` Mark Rutland
2016-06-22 16:05       ` Stephan Linz
2016-06-23  6:40         ` Jacek Anaszewski
2016-06-23 19:38           ` Stephan Linz [this message]
2016-06-24  6:50             ` [PATCH v5] " Jacek Anaszewski
2016-06-24 17:18               ` Stephan Linz
2016-06-08 22:29 ` [PATCH v3 3/7] powerpc: use the new LED disk activity trigger Stephan Linz
2016-06-08 22:29 ` [PATCH v3 4/7] arm: " Stephan Linz
2016-06-09  7:18   ` Gregory CLEMENT
2016-06-08 22:29 ` [PATCH v3 5/7] mips: " Stephan Linz
2016-06-08 22:29 ` [PATCH v3 6/7] parisc: " Stephan Linz
2016-06-08 22:29 ` [PATCH v3 7/7] unicore32: " Stephan Linz
2016-06-09  7:29 ` [PATCH v3 1/7] leds: convert IDE trigger to common disk trigger Jacek Anaszewski
2016-06-09 22:27   ` Stephan Linz
2016-06-20  8:36 ` Jacek Anaszewski
2016-06-20 21:28   ` Stephan Linz
2016-06-21  7:13     ` Jacek Anaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160623193857.14538-1-linz@li-pro.net \
    --to=linz@li-pro.net \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=j.anaszewski@samsung.com \
    --cc=joerg@alea.gnuu.de \
    --cc=josejx@gentoo.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®