mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Eric Dumazet <edumazet@google.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Chris Mason <clm@fb.com>, Arjan van de Ven <arjan@infradead.org>,
	rt@linutronix.de, Rik van Riel <riel@redhat.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	George Spelvin <linux@sciencehorizons.net>,
	Len Brown <lenb@kernel.org>,
	Josh Triplett <josh@joshtriplett.org>
Subject: [patch V3 08/22] net/ipv4/inet: Initialize timers as pinned
Date: Fri, 24 Jun 2016 14:32:08 -0000	[thread overview]
Message-ID: <20160624141722.085540362@linutronix.de> (raw)
In-Reply-To: <20160624140325.554996200@linutronix.de>

[-- Attachment #1: netipv4inet_Initialize_timers_as_pinned.patch --]
[-- Type: text/plain, Size: 2308 bytes --]

Pinned timers must carry that attribute in the timer itself. No functional
change.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Chris Mason <clm@fb.com>
Cc: Eric Dumazet <edumazet@google.com>
Cc: rt@linutronix.de
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Arjan van de Ven <arjan@infradead.org>

---
 net/ipv4/inet_connection_sock.c |    7 ++++---
 net/ipv4/inet_timewait_sock.c   |    5 +++--
 2 files changed, 7 insertions(+), 5 deletions(-)

--- a/net/ipv4/inet_connection_sock.c
+++ b/net/ipv4/inet_connection_sock.c
@@ -603,7 +603,7 @@ static void reqsk_timer_handler(unsigned
 		if (req->num_timeout++ == 0)
 			atomic_dec(&queue->young);
 		timeo = min(TCP_TIMEOUT_INIT << req->num_timeout, TCP_RTO_MAX);
-		mod_timer_pinned(&req->rsk_timer, jiffies + timeo);
+		mod_timer(&req->rsk_timer, jiffies + timeo);
 		return;
 	}
 drop:
@@ -617,8 +617,9 @@ static void reqsk_queue_hash_req(struct
 	req->num_timeout = 0;
 	req->sk = NULL;
 
-	setup_timer(&req->rsk_timer, reqsk_timer_handler, (unsigned long)req);
-	mod_timer_pinned(&req->rsk_timer, jiffies + timeout);
+	setup_pinned_timer(&req->rsk_timer, reqsk_timer_handler,
+			    (unsigned long)req);
+	mod_timer(&req->rsk_timer, jiffies + timeout);
 
 	inet_ehash_insert(req_to_sk(req), NULL);
 	/* before letting lookups find us, make sure all req fields
--- a/net/ipv4/inet_timewait_sock.c
+++ b/net/ipv4/inet_timewait_sock.c
@@ -188,7 +188,8 @@ struct inet_timewait_sock *inet_twsk_all
 		tw->tw_prot	    = sk->sk_prot_creator;
 		atomic64_set(&tw->tw_cookie, atomic64_read(&sk->sk_cookie));
 		twsk_net_set(tw, sock_net(sk));
-		setup_timer(&tw->tw_timer, tw_timer_handler, (unsigned long)tw);
+		setup_pinned_timer(&tw->tw_timer, tw_timer_handler,
+				   (unsigned long)tw);
 		/*
 		 * Because we use RCU lookups, we should not set tw_refcnt
 		 * to a non null value before everything is setup for this
@@ -248,7 +249,7 @@ void __inet_twsk_schedule(struct inet_ti
 
 	tw->tw_kill = timeo <= 4*HZ;
 	if (!rearm) {
-		BUG_ON(mod_timer_pinned(&tw->tw_timer, jiffies + timeo));
+		BUG_ON(mod_timer(&tw->tw_timer, jiffies + timeo));
 		atomic_inc(&tw->tw_dr->tw_count);
 	} else {
 		mod_timer_pending(&tw->tw_timer, jiffies + timeo);

  parent reply	other threads:[~2016-06-24 14:40 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-24 14:32 [patch V3 00/22] timer: Refactor the timer wheel Thomas Gleixner
2016-06-24 14:32 ` [patch V3 01/22] timer: Make pinned a timer property Thomas Gleixner
2016-07-01 13:03   ` Frederic Weisbecker
2016-06-24 14:32 ` [patch V3 02/22] x86/apic/uv: Initialize timer as pinned Thomas Gleixner
2016-06-24 14:32 ` [patch V3 03/22] x86/mce: " Thomas Gleixner
2016-06-24 14:32 ` [patch V3 04/22] cpufreq/powernv: " Thomas Gleixner
2016-06-24 14:32 ` [patch V3 05/22] driver/net/ethernet/tile: " Thomas Gleixner
2016-06-24 14:32 ` [patch V3 06/22] drivers/tty/metag_da: " Thomas Gleixner
2016-06-24 14:32 ` [patch V3 07/22] drivers/tty/mips_ejtag: " Thomas Gleixner
2016-06-24 14:32 ` Thomas Gleixner [this message]
2016-06-24 14:32 ` [patch V3 09/22] timer: Remove mod_timer_pinned Thomas Gleixner
2016-06-24 14:32 ` [patch V3 10/22] signal: Use hrtimer for sigtimedwait Thomas Gleixner
2016-06-24 14:32 ` [patch V3 11/22] hlist: Add hlist_is_singular_node() helper Thomas Gleixner
2016-06-24 14:32 ` [patch V3 12/22] timer: Give a few structs and members proper names Thomas Gleixner
2016-06-24 14:32 ` [patch V3 13/22] timer: Reduce the CPU index space to 256k Thomas Gleixner
2016-07-01 14:41   ` Frederic Weisbecker
2016-06-24 14:32 ` [patch V3 14/22] timer: Switch to a non cascading wheel Thomas Gleixner
2016-06-24 14:32 ` [patch V3 15/22] timer: Remove slack leftovers Thomas Gleixner
2016-06-24 14:32 ` [patch V3 16/22] timer: Move __run_timers() function Thomas Gleixner
2016-06-24 14:32 ` [patch V3 17/22] timer: Optimize collect timers for NOHZ Thomas Gleixner
2016-06-24 14:32 ` [patch V3 18/22] tick/sched: Remove pointless empty function Thomas Gleixner
2016-06-24 14:32 ` [patch V3 19/22] timer: Forward wheel clock whenever possible Thomas Gleixner
2016-06-24 20:45   ` Richard Cochran
2016-06-25  8:55     ` Thomas Gleixner
2016-06-24 14:32 ` [patch V3 20/22] timer: Only wake softirq if necessary Thomas Gleixner
2016-06-24 14:32 ` [patch V3 21/22] timer: Split out index calculation Thomas Gleixner
2016-06-24 14:32 ` [patch V3 22/22] timer: Optimization for same expiry time in mod_timer() Thomas Gleixner
2016-06-24 17:04 ` [patch V3 00/22] timer: Refactor the timer wheel Josh Triplett
2016-06-27  4:22 ` Paul E. McKenney
2016-06-27 23:56   ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160624141722.085540362@linutronix.de \
    --to=tglx@linutronix.de \
    --cc=arjan@infradead.org \
    --cc=clm@fb.com \
    --cc=edumazet@google.com \
    --cc=fweisbec@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@sciencehorizons.net \
    --cc=mingo@kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    --cc=rt@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®