From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751587AbcFYRZA (ORCPT ); Sat, 25 Jun 2016 13:25:00 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:49872 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751123AbcFYRY7 (ORCPT ); Sat, 25 Jun 2016 13:24:59 -0400 Date: Sat, 25 Jun 2016 10:25:00 -0700 From: Greg Kroah-Hartman To: zengzhaoxiu@163.com Cc: linux-kernel@vger.kernel.org, Zhaoxiu Zeng , Jiri Slaby , linux-serial@vger.kernel.org Subject: Re: [patch V4 27/31] serial: use parity32 in max3100 Message-ID: <20160625172500.GA18790@kroah.com> References: <1462955158-28394-1-git-send-email-zengzhaoxiu@163.com> <1462958587-25987-1-git-send-email-zengzhaoxiu@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462958587-25987-1-git-send-email-zengzhaoxiu@163.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 11, 2016 at 05:23:07PM +0800, zengzhaoxiu@163.com wrote: > From: Zhaoxiu Zeng > > Signed-off-by: Zhaoxiu Zeng > Acked-by: Greg Kroah-Hartman > --- > drivers/tty/serial/max3100.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/max3100.c b/drivers/tty/serial/max3100.c > index 5c4c280..a0cc84a 100644 > --- a/drivers/tty/serial/max3100.c > +++ b/drivers/tty/serial/max3100.c > @@ -155,7 +155,7 @@ static int max3100_do_parity(struct max3100_port *s, u16 c) > else > c &= 0xff; > > - parity = parity ^ (hweight8(c) & 1); > + parity ^= parity8(c); Your subject does not match the patch, and there is no changelog text so I can't take it :( Please fix up. greg k-h