From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751775AbcFZBPV (ORCPT ); Sat, 25 Jun 2016 21:15:21 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:41862 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751379AbcFZBPS (ORCPT ); Sat, 25 Jun 2016 21:15:18 -0400 Date: Sun, 26 Jun 2016 02:15:00 +0100 From: Mark Brown To: Michal Suchanek Cc: Greg Kroah-Hartman , Ingo Molnar , Andrew Morton , Kees Cook , Thomas Gleixner , Dan Williams , Tejun Heo , "Paul E. McKenney" , Davidlohr Bueso , Andrey Ryabinin , Nikolay Aleksandrov , Dmitry Vyukov , Adrien Schildknecht , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org Message-ID: <20160626011500.GF28202@sirena.org.uk> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8JAmzYDSl0Sjbh5d" Content-Disposition: inline In-Reply-To: X-Cookie: Beware of Bigfoot! User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 2/3] spi: of: allow instantiating slaves without a driver X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --8JAmzYDSl0Sjbh5d Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 23, 2016 at 05:41:20PM -0000, Michal Suchanek wrote: > SPI slave devices are not created when looking up driver for the slave > fails. Create a device anyway so it can be manually bound to a driver. > @@ -1543,11 +1542,10 @@ of_register_spi_device(struct spi_master *master,= struct device_node *nc) > /* Device speed */ > rc =3D of_property_read_u32(nc, "spi-max-frequency", &value); > if (rc) { > - dev_err(&master->dev, "%s has no valid 'spi-max-frequency' property (%= d)\n", > + dev_warn(&master->dev, "%s has no valid 'spi-max-frequency' property (= %d)\n", > nc->full_name, rc); > - goto err_out; > - } > - spi->max_speed_hz =3D value; > + } else > + spi->max_speed_hz =3D value; > =20 I can't relate this hunk to the changelog and there's a coding style problem, if there's { } on one side of an if statement it should be on both sides. Why are we making this change? --8JAmzYDSl0Sjbh5d Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXbyyTAAoJECTWi3JdVIfQthYH/0/FesGL9pQ7W79XcKvvmHp4 QAS4srcF10Z070N8LKsIxM1fVFV0KDNl5TdFxivu7uBZimlV2w0cZjSivosaZ8/1 goWpVpYwH2DLs+y8TecLNbNOUvl5mT6/MRak69+HHwL71UY5Zgzf/LrdTCKKPnFt GRayD7qp5evYAXPldrDq0JT7M3Rp6YqWmBM7ag9Rdkqhzw2pENQxbev5TiVDID4L CmjM7I3b8jF2ZGZuvJNQdKSCWdfFdsBpWvI4LSijoa/y+wQhY5M5542gGWtLhl82 QXGVTSJEP3EZhQZ2laUQvj9TLP9bZDyD3Pa9xFUlzicqV4of4SnsXiElwa1a74Y= =EKtd -----END PGP SIGNATURE----- --8JAmzYDSl0Sjbh5d--