From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751798AbcFZBR4 (ORCPT ); Sat, 25 Jun 2016 21:17:56 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:41892 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751587AbcFZBRy (ORCPT ); Sat, 25 Jun 2016 21:17:54 -0400 Date: Sun, 26 Jun 2016 02:17:37 +0100 From: Mark Brown To: Michal Suchanek Cc: Greg Kroah-Hartman , Ingo Molnar , Andrew Morton , Kees Cook , Thomas Gleixner , Dan Williams , Tejun Heo , "Paul E. McKenney" , Davidlohr Bueso , Andrey Ryabinin , Nikolay Aleksandrov , Dmitry Vyukov , Adrien Schildknecht , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org Message-ID: <20160626011737.GG28202@sirena.org.uk> References: <5e0397742f887f656d67bb0d61c8e10782c0e5af.1466696079.git.hramrach@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="YYM4jLJxzFJ63wjS" Content-Disposition: inline In-Reply-To: <5e0397742f887f656d67bb0d61c8e10782c0e5af.1466696079.git.hramrach@gmail.com> X-Cookie: Beware of Bigfoot! User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 3/3] drivers core: allow id match override when manually binding driver X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --YYM4jLJxzFJ63wjS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jun 23, 2016 at 05:41:20PM -0000, Michal Suchanek wrote: > This allows binding spidev on any slave device by hand using sysfs > without adding superfluous compatibles or any other needless > complication. This says "spidev" but it's a change to the driver core, not something that is specific to spidev. It needs to be explained in terms ofn the driver core, especially given that other runtime ID setting is done in a particular bus. > +menuconfig DRIVER_MATCH_OVERRIDE > + bool "Allow manual driver binding to override id match (DANGEROUS)" > + default n > + help > + When binding a driver manually bypass the check of driver id table > + against device id in driver core. This can be useful for development > + or on buses that don't provide reliable device identification. > + > +config DRIVER_MATCH_OVERRIDE_BUSES > + string "Specify buses for which id matching will be overridden" > + default "spi" > + depends on DRIVER_MATCH_OVERRIDE > + help > + space separated bus names This doesn't seem at all idomatic for how I'd expect bus features to be implemented, or Linux configuration in general. If we're going to allow a feature like this at the core level we should just allow it, if we're going to opt buses into any such feature I'd expect it to be done unconditionally. --YYM4jLJxzFJ63wjS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXby0wAAoJECTWi3JdVIfQHjsH/0eDFofwg5HVyVflW6kQqEhJ ug8L7HEejtT8tW0Tg6w5ExNWVN0/5w7XmB1PyOMbUz1rGm7VYS6hITDL0iiV95bO jNfEhvCJyuZhdTmCO7zcVO/xu4Hq3Z9ht4oc6/doR5USSAyfqFh9gYCrPxETJ11W wx+i09sXrfxQjE78MNTtgSQYzRULQyjaqxxlRJ5fRkbEGCi+ksIrkqIX2nFwqL9G 1iBr2oAf0o/2ArKpe18lg5TTjcf8ZOU4xSEFnWsB8iu0VuoASPp0opOsZqbGXr0J QEDa2wz8KKveEN+8NYgaGsYAB3rBU28zbBwUMKoGjOvSFZC7invrTmTVLKfxNUs= =EaEQ -----END PGP SIGNATURE----- --YYM4jLJxzFJ63wjS--