From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752599AbcFZLFt (ORCPT ); Sun, 26 Jun 2016 07:05:49 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:42868 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752133AbcFZLFr (ORCPT ); Sun, 26 Jun 2016 07:05:47 -0400 Date: Sun, 26 Jun 2016 12:05:14 +0100 From: Mark Brown To: Michal Suchanek Cc: Greg Kroah-Hartman , Ingo Molnar , Andrew Morton , Kees Cook , Thomas Gleixner , Dan Williams , Tejun Heo , "Paul E. McKenney" , Davidlohr Bueso , Andrey Ryabinin , Nikolay Aleksandrov , Dmitry Vyukov , Adrien Schildknecht , Linux Kernel Mailing List , linux-spi Message-ID: <20160626110514.GI28202@sirena.org.uk> References: <8b66102e44829c5dc445c17f7bfad1050840b9f0.1466696079.git.hramrach@gmail.com> <20160626011315.GE28202@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Y4/B1uKDHmWlpzsz" Content-Disposition: inline In-Reply-To: X-Cookie: Beware of Bigfoot! User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/3] spi: spidev: fix the check for spidev in dt X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Y4/B1uKDHmWlpzsz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Jun 26, 2016 at 04:12:10AM +0200, Michal Suchanek wrote: > On 26 June 2016 at 03:13, Mark Brown wrote: > > On Thu, Jun 23, 2016 at 05:41:19PM -0000, Michal Suchanek wrote: > >> The check is supposed to warn about spidev specified directly in > >> devicetree as compatible. This just does not work. I have a devicetree > >> with no compatible whatsoever and hacked my kernel so I can manually > >> bind spidev. This still triggers. > > Well, a DT device won't instantiate without a compatible string... > > could you please explain exactly what makes you say this won't work? > That's because the whitelist concept for this check is completely broken. > Without any patches whatsoever I should be able to specify m25p80 > binding in the DT, let the kernel create the device, unbind the > driver, and bind spidev. > Then I have the jedec,spi-nor compatible which is not on the whitelist. So, none of that is in the changelog where it needs to be and it only makes sense if we adopt the very specific solution you are proposing. You need to describe this change properly and you need to put it at the end of the patch series were it makes sense. --Y4/B1uKDHmWlpzsz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXb7bpAAoJECTWi3JdVIfQQHcH/2783gp4lSO6PeFdWJnMqoXz pD3ZKnvAyfIkuF54PKjesGjBUR6pkuuLSSB/bYNtyccZh0XZ6RR0Bjv/8ZDeRsyV 77YjjuemmMB6Qnv3PIDv0uqc6OkcdMBgynGWDf9AvGqjM5bd0POxmQYBVjeLwoyE +evaBzJZeJq47uoZX7U/WAeXpBve6P6L1VF5QAUh5ezEEAheXhbAPP7X8IA3wFgt JMjqmESwdZWCX32bH5qxgxPNAdGJxG/fflvTaEdDnupAFm/EbukFKWaIww61ERDG 0Sl+KzJ+JUEPF4bbGjpgQJG4e7uqoStQ53AYFF0U/tBuvIiYW6oUvcr8t2A2N6M= =Ntf4 -----END PGP SIGNATURE----- --Y4/B1uKDHmWlpzsz--