From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751932AbcF0Glx (ORCPT ); Mon, 27 Jun 2016 02:41:53 -0400 Received: from sym2.noone.org ([178.63.92.236]:59388 "EHLO sym2.noone.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751609AbcF0Glv (ORCPT ); Mon, 27 Jun 2016 02:41:51 -0400 X-Greylist: delayed 529 seconds by postgrey-1.27 at vger.kernel.org; Mon, 27 Jun 2016 02:41:51 EDT Date: Mon, 27 Jun 2016 08:32:59 +0200 From: Tobias Klauser To: Philippe Reynes Cc: davem@davemloft.net, andrew@lunn.ch, colin.king@canonical.com, f.fainelli@gmail.com, jcmvbkbc@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] net: ethernet: ethoc: use phydev from struct net_device Message-ID: <20160627063258.GH28466@distanz.ch> References: <1466865222-11840-1-git-send-email-tremyfr@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466865222-11840-1-git-send-email-tremyfr@gmail.com> X-Editor: Vi IMproved 7.3 User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016-06-25 at 16:33:41 +0200, Philippe Reynes wrote: > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phy in the private structure, and update the driver to use the > one contained in struct net_device. In that case the phy member should also be removed from the definition of private struct ethoc in the same patch. Otherwise the patch looks good to me.