From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751913AbcF0ORe (ORCPT ); Mon, 27 Jun 2016 10:17:34 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:46768 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750870AbcF0ORc (ORCPT ); Mon, 27 Jun 2016 10:17:32 -0400 Date: Mon, 27 Jun 2016 15:17:13 +0100 From: Mark Brown To: Octavian Purdila Cc: "Rafael J . Wysocki" , Len Brown , Matt Fleming , Wolfram Sang , Joel Becker , linux-acpi@vger.kernel.org, linux-efi@vger.kernel.org, linux-i2c@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, irina.tirdea@intel.com, leonard.crestez@intel.com Message-ID: <20160627141713.GW28202@sirena.org.uk> References: <1466164336-9508-1-git-send-email-octavian.purdila@intel.com> <1466164336-9508-6-git-send-email-octavian.purdila@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XGH+X5Sk6wksXc5a" Content-Disposition: inline In-Reply-To: <1466164336-9508-6-git-send-email-octavian.purdila@intel.com> X-Cookie: Beware of Bigfoot! User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v4 5/8] spi: add support for ACPI reconfigure notifications X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --XGH+X5Sk6wksXc5a Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 17, 2016 at 02:52:13PM +0300, Octavian Purdila wrote: > This patch adds supports for SPI device enumeration and removal via > ACPI reconfiguration notifications that are send as a result of an > ACPI table load or unload operation. I still have the same concern I've had all the way through here: this is very similar to the equivalent DT code but not quite, especially in regard to the OF_POPULATED flag which has no ACPI equivalent. This gives us ACPI code which just looks like it's missing something. I'd like to see the comparison at least covered in the changelog so people have something to refer to in future when trying to understand why things are done this way. --XGH+X5Sk6wksXc5a Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXcTVoAAoJECTWi3JdVIfQ1NkIAICLFrq20hSWhgkKNPVK2Fxu ZlIUEeByk4Ko38eN/9XzEXP3JrQC5iIOe7or4AneoEpS2urUPg91Ozx0ylZUBzwV 8SLbS3mvDTJ/skvMbC/zbBsLgMiJ8MjFGQbYvE622sgFup+bQ+v070l9fmCmB/MX NqeJO+LKISe68MA6fugIl6cgj2TR9ngvBbrc/tUFl2FXwzyd0yp14MM3uEHpMBSX A097r6EHZTzYQXe3C7V646BHlW2tm8EIi/j1xa5i6ssI+g1SB3Q0TbwOELN7jJ1W 49rA7hTrS5HsUhlYTqE2xyXXg9sMuP94Nf77qNFsFrYdJBkBw/sffitdCvOY28Q= =ikos -----END PGP SIGNATURE----- --XGH+X5Sk6wksXc5a--