From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751951AbcF0QOU (ORCPT ); Mon, 27 Jun 2016 12:14:20 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:47184 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751830AbcF0QOO (ORCPT ); Mon, 27 Jun 2016 12:14:14 -0400 Date: Mon, 27 Jun 2016 17:14:05 +0100 From: Mark Brown To: Venkat Reddy Talla Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org, ldewangan@nvidia.com Message-ID: <20160627161405.GA17217@sirena.org.uk> References: <1467027824-29739-1-git-send-email-vreddytalla@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="82I3+IH0IqGh5yIs" Content-Disposition: inline In-Reply-To: <1467027824-29739-1-git-send-email-vreddytalla@nvidia.com> X-Cookie: Last week's pet, this week's special. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/1] regulator: max77620: check for valid regulator info X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --82I3+IH0IqGh5yIs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jun 27, 2016 at 05:13:44PM +0530, Venkat Reddy Talla wrote: > Check for valid regulator information data before > configuring FPS source and FPS power up/down > period to avoid NULL pointer exception if entries for > PMIC regulators not provided through device tree. This sounds like it's papering over a bug in the driver - the driver should be able to instantiate without anything beyond the registration of the device. What's the driver relying on from the DT? > SD4 regulator is not supported by MAX77620 PMIC, removing > SD4 entry from regulator information list. This appears to be a separate change to the above and should be a separate patch. --82I3+IH0IqGh5yIs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXcVDLAAoJECTWi3JdVIfQ9uEH/ignw8dLtR/AHMtVGYiXWjkY MjjkP5u/sY7JPOOZNl2RjV6XUbOYz/YfsJ5hQnJUgJfwnpRc69U/g7dEFmMsS68Y Xj4Cz49rhnDvZ+H2CN1flmy9VzlpH9MBI+fcheSUQeEdclVt/3ikTdIY9H5497zs FGV818S0rSZXcDep4L7xtpglCv8tQhYxkJWkpUTh4lAJtgb84OkGvPZovgsXm8wK P5dI18Rl9RY8vDVsn+0Ca65EYDfrIvOAL/lNDr0cRknV1U2+VzuMZQz2O/LKuld6 9FfIg5LzTVYoK+BCskzZCkwF0iw0uXX1O9vIhjUomj3gPVgDZdC2GKWaOzuHyFk= =xZPR -----END PGP SIGNATURE----- --82I3+IH0IqGh5yIs--