From: Mark Brown <broonie@kernel.org>
To: Michal Suchanek <hramrach@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-spi <linux-spi@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] drivers core: allow id match override when manually binding driver
Date: Mon, 27 Jun 2016 21:32:33 +0100 [thread overview]
Message-ID: <20160627203233.GH17217@sirena.org.uk> (raw)
In-Reply-To: <CAOMqctQj0ftbOH9dvMPczBPeSFTvDuTKCXgYprYvtcQDYML8Kw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 855 bytes --]
On Mon, Jun 27, 2016 at 09:40:38PM +0200, Michal Suchanek wrote:
> No. It's for buses that have some inherent identification. It's not for
> 1) generate random compatible and stick it in device tree
Don't generate a random compatible, generate one that accurately
describes your hardware.
> also AFAIK new_id is not automagic and not all buses have it.
Yes, this is the bit I've been trying to prompt you to implement rather
than going off doing something broken.
> So it would have to be implemented on SPI. How? On PCI new_id is a PCI
> id. What is it on SPI? ACPI PnP id? DT compatible? How do you tell?
Those sound like sensible ideas.
> And why when the bus does not even have IDs?
Identifiers are just a useful way of describing what the hardware is,
the fact that some of them can be read back from hardware isn't terribly
important here.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-06-27 20:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 19:02 [PATCH v2 0/3] Updated spidev usability patchset Michal Suchanek
2016-06-27 19:02 ` [PATCH v2 1/3] spi: spidev: fix the check for spidev in dt Michal Suchanek
2016-06-27 20:36 ` Mark Brown
2016-06-27 19:02 ` [PATCH v2 2/3] spi: of: allow instantiating slaves without a driver Michal Suchanek
2016-06-27 21:14 ` Mark Brown
2016-06-27 19:02 ` [PATCH v2 3/3] drivers core: allow id match override when manually binding driver Michal Suchanek
2016-06-27 19:09 ` Greg Kroah-Hartman
2016-06-27 19:40 ` Michal Suchanek
2016-06-27 20:32 ` Mark Brown [this message]
2016-06-27 22:12 ` Greg Kroah-Hartman
2016-06-28 12:40 ` Michal Suchanek
2016-06-28 15:51 ` Mark Brown
2016-06-28 16:24 ` Michal Suchanek
2016-06-28 18:38 ` Mark Brown
2016-06-28 20:02 ` Michal Suchanek
2016-06-28 20:57 ` Mark Brown
2016-06-29 3:32 ` Michal Suchanek
2016-06-29 18:02 ` Mark Brown
2016-06-30 7:47 ` Michal Suchanek
2016-06-30 9:03 ` Dan O'Donovan
2016-07-01 9:36 ` Mark Brown
2016-07-01 10:11 ` Michal Suchanek
2016-07-01 8:25 ` Mark Brown
2016-07-01 8:58 ` Michal Suchanek
2016-07-01 15:00 ` Mark Brown
2016-07-01 15:37 ` Michal Suchanek
2016-07-01 16:22 ` Mark Brown
2016-07-01 18:56 ` Michal Suchanek
2016-07-01 19:36 ` Michal Suchanek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160627203233.GH17217@sirena.org.uk \
--to=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hramrach@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®