From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752071AbcF1Fta (ORCPT ); Tue, 28 Jun 2016 01:49:30 -0400 Received: from mail-db3on0119.outbound.protection.outlook.com ([157.55.234.119]:63072 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751956AbcF1Ft0 (ORCPT ); Tue, 28 Jun 2016 01:49:26 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=bhuvanchandra.dv@toradex.com; From: Bhuvanchandra DV To: CC: , , , , , , , , , , "Bhuvanchandra DV" Subject: [PATCH v2 4/9] tty: serial: fsl_lpuart: fix clearing of receive flag Date: Tue, 28 Jun 2016 11:02:30 +0530 Message-ID: <20160628053235.5114-5-bhuvanchandra.dv@toradex.com> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20160628053235.5114-1-bhuvanchandra.dv@toradex.com> References: <20160628053235.5114-1-bhuvanchandra.dv@toradex.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [115.115.243.34] X-ClientProxiedBy: BM1PR01CA0056.INDPRD01.PROD.OUTLOOK.COM (10.163.199.28) To HE1PR0501MB2089.eurprd05.prod.outlook.com (10.167.246.9) X-MS-Office365-Filtering-Correlation-Id: b24067fe-ef12-479a-f72f-08d39f15b94b X-Microsoft-Exchange-Diagnostics: 1;HE1PR0501MB2089;2:sD+d4pI+osnnkeD9HKcwd7HYmGjNoOUL1NcAqLvrLFTdH9rpWoRCTT2RtKn9CdlE84QgdNX2+9kO0aK4xehRadsCfn5Qm73ZchSZfFNEf9ehpCeUJOxq55OAp5d0k/vbkjus6F9BoDEka7iy99/XPTEThHaU4uWzp6S8C6CRkSQBZ0u1RDDtWZNvCpoA6kEc;3:3/C5PqZbaZIuaXL7GgS7Vm0RoJ2u4MLo6mQoFU4/JeHbCSmHMhorZm76RaxOQs/Z3dPRW2Bptn2adiB4c+PUlnvBFh/vliNaIcKIax057CxxjBOfvHkwKdLrZmiUmuxW X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0501MB2089; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0501MB2089;25:/wZ4qwuqCD5VX39yyEFfpDohH7sP9O83QAJHIFCGaLtqJ+YInq34wRvJ5ZbemiWc4TSRpuFEspBYUXzKRFKoX1//jX6T+H625h45X0WaeaENAQxDnp4+ejz1kYPMdkWBFPYuCreYj1DUp3DiZp66k0i2O90MABBL5LPJtUI3YahmMHkG2Ox1jninl56cb8erk1h4abrt8P8tu5iUoavUe+0iJnT6rYg1e50uzQ0gCIBbizHjfv1t1LVI2mYBOQfFEIePKtySA1rrFYjWR0lXylfSL8bvqok/PEDrv/EBOQoebCZ/eGcjJC5uO+d3uYPsp15WFLb8rNj6D13SqP+0SgQlXWuKnubcy/6cezhQ1V5JFewGs3rbikIZxzt12fg+zNE6mIWh+ugm85NpNlNMCUPcWUHez758EfDWGwddr+HTPtQnyyeX15dwGSCZcP8HJ9tnFLjAoyhI+MYZ3uSU75xumT9wmfWYsgLqZcy90kNhvbvykqo74A1CclYaY8RFbL9XUs6OhBQSqA0jo8VDp7ptlwgzuAgnYwqtXVGMQRz+9OlCimCt2hSIwMo1XCUbUuHuN3FuFiNDyg5auQ8HR3849SAgOxY9+/8M9GkfwbDlpmMLdNGKU7PukQkGoGwYlMaGVPSviXHaMpArWZn4kCc3H9v6DaPSBv+CfOmxjJoaoVhIiXYzaNXw+e+WzwRoGJ3F8ffp0EnrI5j6l6QVzIT2Q8Hvj/PS/GB7Tx5I/f8= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0501MB2089;20:ym72qQ5W7DEsIDhM4yeu1VBhWecxUHJcKzojnWi0j0oGJyIqthpCxxwE49Ax1sHh2g82v3cnDdJaCelvlol4KsE0VVeGh3wZCTYWehp3wEo7ucgXoC0Papt5lstR9LjhW7H9p1whjvZDal6VPv9j3eSvGQMbyW6eo9qgRPc3V4vDJv7rxtj+9vhJNht8/xXvPmDA2l4nR05bertxNMW9vKufwGttRIKlToJLoyO5R/oozza3et86RHNgxwgD9a/PJueHZ6a8GFKRIiY/irJ9xBkly30ft48JF0v+JxB1nzj+gemOeCVWJorOA7q3GPlVN0phcM1y5ySUCrVEFBXoxA==;4:T0rsK6cOPf9/VMoQV7416xUKmYKDqI8f/JTgsxD5ibsvMIrdaPEKR3LMNEqSp32hdn+W7lS++lrztsNK5xmaQqPMHViiQEv0smTjbh+x9HvYdQUN8rJ5x3oZI2daigy0GlBPSkW+31V6YBhbx+4h67pw8vt/DiLzw/55j+q1HkqqQiQLAzBqSFJDTGhyoEEHNKgo/283b23CGENpaAhP534s77nl63v+4Oy1+kES/xhOVKnuT7oROSmRfnhJLcPQRoezHMlU2o4Bhg5+PQZG5B1s90vcaO4JMEcsqnmz0OXmYB4Df4hD/P/EAfR/bxD4YuH84e+uDFyeKf3QfmEDQJtMJEmfZJn5qdTuq7larlA0G0QHGXlF1n0y2j0TTx15 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:HE1PR0501MB2089;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0501MB2089; X-Forefront-PRVS: 0987ACA2E2 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(199003)(189002)(189998001)(50226002)(110136002)(107886002)(7846002)(47776003)(66066001)(36756003)(8676002)(101416001)(1076002)(48376002)(33646002)(6116002)(81166006)(92566002)(3846002)(50986999)(586003)(81156014)(50466002)(2351001)(2950100001)(77096005)(105586002)(229853001)(86362001)(76176999)(5003940100001)(68736007)(305945005)(106356001)(4326007)(7736002)(53416004)(4001430100002)(19580405001)(19580395003)(69596002)(42186005)(97736004)(2906002);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR0501MB2089;H:tdx-in-nb-0014.toradex.ext;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;HE1PR0501MB2089;23:ztZohbZo16lvgOLusrl0R+xuezWNU4eror+CGRA?= =?us-ascii?Q?X1qpONJ4HEdq7TMA6WFhfMGymFxdlT52WNxRMJtfB40knzy4amfP3FQ2oflI?= =?us-ascii?Q?yktplBLowbbxV6S8jepse4WNLfDgVpLHFMb56uVLw6ogYeXbNE1fO8OgUzyo?= =?us-ascii?Q?koUzYGMOY3gT23YJ6Iz1WIBATUSI6P3iBqWPbP8SfhQjz6L6KrsPnhCgYI9e?= =?us-ascii?Q?Nz/Wxxc7dOInkn2ODEdrqb0ek2Q6Da/NcUmuFy0xAKURTrx0vp9F37akmfLo?= =?us-ascii?Q?URUXnodU6vm3fjtHuWHAqz0niWT6e9fggTBr0zWAAZtdhfiMCoUKM1nJPizY?= =?us-ascii?Q?Q+mGFwSigUtj34Iu0PDT2SQYouDZMtJXsJ+zXYsA6Sr0IYDO+kgrA6Y7Grns?= =?us-ascii?Q?GONdJ4n0YQaKgWdLvMFUiTbAlYA/m8i9mYoN3zkVL9olvVACwP3qBlyFNF2P?= =?us-ascii?Q?moi1R3Dt9R/shOaSWLSN9F3I7IPw3aMwyGMHEaePazmbUlJ+jAHGar0f1qeb?= =?us-ascii?Q?7TqCDoEpIqTiCH402Eh9XGCR2m3sPLKhUDjSENxqJ13qYzykF28c72Xu/2Wg?= =?us-ascii?Q?nnD8V4D7V3mKyrI/ztInRiD6LBFFHE+YiRS2IakFhWKkbZ6oHJgBHB31D4M0?= =?us-ascii?Q?R/xJA638X4wWqQXPQF2kEAmlrDQQM5ovJFYh4OPH3/5eA7aDCirQkIBXLoyj?= =?us-ascii?Q?rCMHVD2uD4PiieYHGV1DNEXS9USbXhJTxAM49pJgfPChlMPiQoBQjCrU/g/B?= =?us-ascii?Q?GnxLHWCAd/q/I1vYeImhGppDea1WxDTI5j9/nxf5UfHwuEF7wA+5qv6suvzH?= =?us-ascii?Q?SV/+6o/HCf71P3QU1M6faQFk/N101OFo4GGFW1yLSo6R9jb5ap9GWC1s4FWJ?= =?us-ascii?Q?nNOSDn9zGt3vJalwIJy3qbaTpCq04wj7gr7J9mRZf9w22pY30psatJ+HnbsE?= =?us-ascii?Q?O+0bboKzK0kxt/IwUDeoZJUpM1h7nHzvj301EYGrAv/qS0Te8aZ/GLfQ+3cn?= =?us-ascii?Q?4xIBInOmkf7otUN+VIYuLJu5TN/y1fxf/l1iVzI/Nd+gz6djr4oz8OHPVljb?= =?us-ascii?Q?4O21iA8L037p9uRKrm59BAl22/xfoPkpeWtItUTIhPCjP2+iprZ86LfjHaWa?= =?us-ascii?Q?Gk9V4uQpmKovh3NRV1KNjaxwKqAhQhfRrEW/cJ9FLEKH8SRghwsg1vY9o9vh?= =?us-ascii?Q?kkC6YSzLfOAGHqWs=3D?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0501MB2089;6:0Q+1tYwxiGAbcvor+Er0O2GZagL69xaRw6QrcL4eroC4+mm0k6WYU4iIzt7nDIrsdqaVFsFQvIzaUpl04A/DGkpE4NxS2Jm/zPNgP9exghsULyhxCeD/GiwRINP6aAUmRj+ev3V5i3lPvjYSiGmrMgjOS08L0qAyW1aVy3gQMpI1UoZoitBmPeQN/qzKOgnceOdncRl3FuUQYfjn5+UCsh4LORlawhItC/J0MYxFmkNc0H6R3jYu4cCELd4d7A7bIumIZVFUJLIGdIRtWRUhrQ68Jb+AHgbbYhtIZXW5glXulX3SFg0UQR7+4zgRIu+r;5:xMKNLgFsWiP9RJ+RN8fZsRzU1lyQl2O1GwneV6oqHP/um4pbgKKtdxIdUZLuAyTNGuWN71jPuCQ5AixNyRulquxFlTR/aHfXAqW6icF57rKIPCRv5H5qI3+3PCfNdByfrngJX6TyxcT7qHY5ogbKfg==;24:1acrFpB9gfYBF2xf3jIDdgODziertuOjC9hVpEvo6Pwn0GZ7xSzB0C7j0zXS/AR0gI2kJpMiSjuS5Y29CCaqWtAjRvWg2zca7K2MGJGr3i4=;7:EoU1fF1eBaJf8a7nkMEP1iSD8jIzO/wXhIfJhuUFTq9qNEo3MoTo0fcKvMdVUAX8l+Nd5/ssDh8QdBMKfX/WBdJbPc3EoIzU5THw9AffC2whieFpHpssGOI9yD9xgA2Mtyvyn88Wnh7c2/dLZYKrujnU+UwK002m3x64sP0Ijvxod0bxYdWu0CkoH1baxGNkAxwP9r3RmrgEu7b0Q/49Y+vRwd22HlE4rX0rcjRJsnPsXued4Mn4QLU5a/dG4IfHtLk+Qb65YDK4rNHRdkr4ag== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: toradex.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2016 05:33:21.7903 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2089 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stefan Agner Commit 8e4934c6d6c6 ("tty: serial: fsl_lpuart: clear receive flag on FIFO flush") implemented clearing of the receive flag by reading the status register only. It turned out that even though we flush the FIFO afterwards, a explicit read of the data register is still required. This leads to a FIFO underrun. To avoid this, follow the advice in the overrun "Operation section": Unconditionally clear RXUF after using RXFLUSH. Signed-off-by: Stefan Agner Signed-off-by: Bhuvanchandra DV --- drivers/tty/serial/fsl_lpuart.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index 75a2098..97c1fda 100644 --- a/drivers/tty/serial/fsl_lpuart.c +++ b/drivers/tty/serial/fsl_lpuart.c @@ -935,13 +935,16 @@ static void lpuart_setup_watermark(struct lpuart_port *sport) writeb(val | UARTPFIFO_TXFE | UARTPFIFO_RXFE, sport->port.membase + UARTPFIFO); - /* explicitly clear RDRF */ - readb(sport->port.membase + UARTSR1); - /* flush Tx and Rx FIFO */ writeb(UARTCFIFO_TXFLUSH | UARTCFIFO_RXFLUSH, sport->port.membase + UARTCFIFO); + /* explicitly clear RDRF */ + if (readb(sport->port.membase + UARTSR1) & UARTSR1_RDRF) { + readb(sport->port.membase + UARTDR); + writeb(UARTSFIFO_RXUF, sport->port.membase + UARTSFIFO); + } + writeb(0, sport->port.membase + UARTTWFIFO); writeb(1, sport->port.membase + UARTRWFIFO); -- 2.9.0