From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752430AbcF1IG0 (ORCPT ); Tue, 28 Jun 2016 04:06:26 -0400 Received: from mail.fireflyinternet.com ([87.106.93.118]:53646 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752077AbcF1IGV (ORCPT ); Tue, 28 Jun 2016 04:06:21 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Date: Tue, 28 Jun 2016 09:06:04 +0100 From: Chris Wilson To: Jani Nikula Cc: Randy Dunlap , LKML , "linux-next@vger.kernel.org" , Daniel Vetter , Jani Nikula , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, drm-intel-fixes@lists.freedesktop.org Subject: Re: [PATCH] drm/i915: fix build errors when ACPI is not enabled Message-ID: <20160628080604.GC25424@nuc-i3427.alporthouse.com> Mail-Followup-To: Chris Wilson , Jani Nikula , Randy Dunlap , LKML , "linux-next@vger.kernel.org" , Daniel Vetter , Jani Nikula , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, drm-intel-fixes@lists.freedesktop.org References: <576EC660.3000806@infradead.org> <1467028399-9965-1-git-send-email-jani.nikula@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1467028399-9965-1-git-send-email-jani.nikula@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 27, 2016 at 02:53:19PM +0300, Jani Nikula wrote: > From: Randy Dunlap > > Fix build errors when ACPI is not enabled by adding function stubs: > > ../drivers/gpu/drm/i915/i915_drv.c: In function 'i915_drm_suspend': > ../drivers/gpu/drm/i915/i915_drv.c:635:2: error: implicit declaration of function 'intel_opregion_unregister' [-Werror=implicit-function-declaration] > intel_opregion_unregister(dev_priv); > ../drivers/gpu/drm/i915/i915_drv.c: In function 'i915_drm_resume': > ../drivers/gpu/drm/i915/i915_drv.c:798:2: error: implicit declaration of function 'intel_opregion_register' [-Werror=implicit-function-declaration] > intel_opregion_register(dev_priv); > > Signed-off-by: Randy Dunlap > Cc: Daniel Vetter > Cc: Jani Nikula > Cc: intel-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Fixes: 03d92e4779b8 ("drm/i915/opregion: Rename init/fini functions to register/unregister") > Cc: drm-intel-fixes@lists.freedesktop.org > Cc: Chris Wilson > [Jani: dropped the stale init/fini declarations] > Signed-off-by: Jani Nikula Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre